Enhance plugin loading with improved error handling and file reading logic

This commit is contained in:
Thorsten Sommer 2025-04-27 15:32:48 +02:00
parent b1319fac6e
commit a3a1483c84
No known key found for this signature in database
GPG Key ID: B0B7E2FC074BF1F5

View File

@ -54,12 +54,21 @@ public static partial class PluginFactory
// //
var pluginMainFiles = Directory.EnumerateFiles(PLUGINS_ROOT, "plugin.lua", SearchOption.AllDirectories); var pluginMainFiles = Directory.EnumerateFiles(PLUGINS_ROOT, "plugin.lua", SearchOption.AllDirectories);
foreach (var pluginMainFile in pluginMainFiles) foreach (var pluginMainFile in pluginMainFiles)
{
try
{ {
if (cancellationToken.IsCancellationRequested) if (cancellationToken.IsCancellationRequested)
break; break;
LOG.LogInformation($"Try to load plugin: {pluginMainFile}"); LOG.LogInformation($"Try to load plugin: {pluginMainFile}");
var code = await File.ReadAllTextAsync(pluginMainFile, Encoding.UTF8, cancellationToken); var fileInfo = new FileInfo(pluginMainFile);
string code;
await using(var fileStream = fileInfo.Open(FileMode.Open, FileAccess.Read, FileShare.ReadWrite))
{
using var reader = new StreamReader(fileStream, Encoding.UTF8);
code = await reader.ReadToEndAsync(cancellationToken);
}
var pluginPath = Path.GetDirectoryName(pluginMainFile)!; var pluginPath = Path.GetDirectoryName(pluginMainFile)!;
var plugin = await Load(pluginPath, code, cancellationToken); var plugin = await Load(pluginPath, code, cancellationToken);
@ -89,6 +98,12 @@ public static partial class PluginFactory
LOG.LogInformation($"Successfully loaded plugin: '{pluginMainFile}' (Id='{plugin.Id}', Type='{plugin.Type}', Name='{plugin.Name}', Version='{plugin.Version}', Authors='{string.Join(", ", plugin.Authors)}')"); LOG.LogInformation($"Successfully loaded plugin: '{pluginMainFile}' (Id='{plugin.Id}', Type='{plugin.Type}', Name='{plugin.Name}', Version='{plugin.Version}', Authors='{string.Join(", ", plugin.Authors)}')");
AVAILABLE_PLUGINS.Add(new PluginMetadata(plugin, pluginPath)); AVAILABLE_PLUGINS.Add(new PluginMetadata(plugin, pluginPath));
} }
catch (Exception e)
{
LOG.LogError($"Was not able to load plugin '{pluginMainFile}'. Issue: {e.Message}");
LOG.LogDebug(e.StackTrace);
}
}
// Start or restart all plugins: // Start or restart all plugins:
await RestartAllPlugins(cancellationToken); await RestartAllPlugins(cancellationToken);