Upgraded to .NET 10 (#1147)

app/Tests/Tools/DocumentRunProgressTests.cs

@@ -38,12 +38,12 @@ public sealed class DocumentRunProgressTests
         progress.RecordStillUnreadable("/tmp/test-data/scan.pdf", new PermanentIndexingFailureRecord("AAAA", FileExtractionErrorCode.NO_TEXT_EXTRACTED, "No text could be read.", DateTimeOffset.UtcNow));
         await progress.RecordDocumentFailureAsync(Document("/tmp/test-data/report.pdf"), new ProviderRequestException(ProviderRequestFailureReason.INVALID_OR_MISSING_API_KEY, "The API key was rejected."), CancellationToken.None);
 
-        Assert.Multiple(() =>
+        using (Assert.EnterMultipleScope())
         {
             Assert.That(statuses[^1].FailedDocuments, Is.EqualTo(1));
             Assert.That(statuses[^1].LastError, Is.EqualTo("The API key was rejected."), "The provider said what to do, and that is what the user reads.");
             Assert.That(statuses[^1].PermanentlySkippedDocuments, Is.EqualTo(1), "The scanned file is still done. Dropping it from the status made the bar jump back after every provider failure.");
-        });
+        }
     }
 
     [Test]
@@ -54,13 +54,13 @@ public sealed class DocumentRunProgressTests
 
         await progress.RecordDocumentFailureAsync(document, new FileExtractionException(FileExtractionErrorCode.NO_TEXT_EXTRACTED, "No text."), CancellationToken.None);
 
-        Assert.Multiple(() =>
+        using (Assert.EnterMultipleScope())
         {
             Assert.That(manifest.PermanentFailures.Keys, Is.EquivalentTo([document.State.AbsolutePath]), "The mark is what keeps the document from being read again until it changes.");
             Assert.That(manifest.PermanentFailures[document.State.AbsolutePath].Fingerprint, Is.EqualTo(document.State.Fingerprint), "The fingerprint decides when the document deserves another attempt.");
             Assert.That(statuses[^1].FailedDocuments, Is.Zero, "A document which cannot be read for a reason of its own is not a failure of the run.");
             Assert.That(statuses[^1].PermanentlySkippedDocuments, Is.EqualTo(1));
-        });
+        }
     }
 
     [Test]
@@ -74,14 +74,14 @@ public sealed class DocumentRunProgressTests
             new FileExtractionException(FileExtractionErrorCode.MEDIA_PROCESSING_FAILED, "The media file is damaged or its format could not be identified."),
             CancellationToken.None);
 
-        Assert.Multiple(() =>
+        using (Assert.EnterMultipleScope())
         {
             Assert.That(statuses[^1].Failures, Has.Count.EqualTo(1));
             Assert.That(statuses[^1].Failures[0].ExtractionCode, Is.EqualTo(FileExtractionErrorCode.MEDIA_PROCESSING_FAILED));
             Assert.That(statuses[^1].Failures[0].Reason, Does.Contain("The media file is damaged or its format could not be identified."));
             Assert.That(manifest.PermanentFailures[document.State.AbsolutePath].Code, Is.EqualTo(FileExtractionErrorCode.MEDIA_PROCESSING_FAILED));
             Assert.That(manifest.PermanentFailures[document.State.AbsolutePath].Message, Is.EqualTo(statuses[^1].Failures[0].Reason));
-        });
+        }
     }
 
     [Test]
@@ -93,13 +93,13 @@ public sealed class DocumentRunProgressTests
         progress.RecordStillUnreadable("/tmp/test-data/scan.pdf", new PermanentIndexingFailureRecord("AAAA", FileExtractionErrorCode.NO_TEXT_EXTRACTED, "No text could be read.", DateTimeOffset.UtcNow));
         await progress.CompleteRunAsync("SOURCE-HASH", "test", CancellationToken.None);
 
-        Assert.Multiple(() =>
+        using (Assert.EnterMultipleScope())
         {
             Assert.That(statuses[^1].State, Is.EqualTo(DataSourceEmbeddingState.COMPLETED), "Nothing is left to try, so the data source must not ask for attention forever.");
             Assert.That(statuses[^1].IndexedDocuments, Is.EqualTo(2));
             Assert.That(statuses[^1].ProgressPercent, Is.EqualTo(100));
             Assert.That(statuses[^1].Failures, Has.Count.EqualTo(1), "The stored reason keeps its place in the list, so the user still sees why.");
-        });
+        }
     }
 
     [Test]
@@ -110,12 +110,12 @@ public sealed class DocumentRunProgressTests
         await progress.RecordDocumentFailureAsync(Document("/tmp/test-data/report.pdf"), new IOException("The file changed."), CancellationToken.None);
         await progress.CompleteRunAsync("SOURCE-HASH", "test", CancellationToken.None);
 
-        Assert.Multiple(() =>
+        using (Assert.EnterMultipleScope())
         {
             Assert.That(statuses[^1].State, Is.EqualTo(DataSourceEmbeddingState.FAILED));
             Assert.That(statuses[^1].LastError, Is.Not.Empty, "A failed run says why, or at least where to look.");
             Assert.That(statuses[^1].Failures.Select(failure => failure.DocumentKey), Is.EquivalentTo(["/tmp/test-data/report.pdf"]));
-        });
+        }
     }
 
     [Test]
@@ -126,12 +126,12 @@ public sealed class DocumentRunProgressTests
         progress.RecordUnchanged(4);
         var outcome = await progress.PauseRunAsync("SOURCE-HASH", "test", CancellationToken.None);
 
-        Assert.Multiple(() =>
+        using (Assert.EnterMultipleScope())
         {
             Assert.That(outcome, Is.EqualTo(IndexedRunOutcome.MORE_TO_DO));
             Assert.That(manifest.SourceHash, Is.EqualTo("SOURCE-HASH"), "Without the hash, a mailbox stays out of every search for the hours its first sync takes.");
             Assert.That(statuses, Is.Empty, "The status said the run is over, while the next one is about to carry on.");
-        });
+        }
     }
 
     [Test]
@@ -143,12 +143,12 @@ public sealed class DocumentRunProgressTests
         progress.RecordUnchanged(4);
         var outcome = await progress.PauseRunAsync(null, "test", CancellationToken.None);
 
-        Assert.Multiple(() =>
+        using (Assert.EnterMultipleScope())
         {
             Assert.That(outcome, Is.EqualTo(IndexedRunOutcome.MORE_TO_DO));
             Assert.That(manifest.SourceHash, Is.EqualTo("HASH-OF-THE-LAST-COMPLETE-RUN"), "The hash says that a run got through the whole folder. A half-indexed folder would count as complete, and the next run would skip it.");
             Assert.That(statuses, Is.Empty);
-        });
+        }
     }
 
     [Test]
@@ -161,13 +161,13 @@ public sealed class DocumentRunProgressTests
         await progress.RecordDocumentFailureAsync(Document("/tmp/test-data/b.pdf"), providerDown, CancellationToken.None);
         var outcome = await progress.PauseRunAsync(null, "test", CancellationToken.None);
 
-        Assert.Multiple(() =>
+        using (Assert.EnterMultipleScope())
         {
             Assert.That(outcome, Is.EqualTo(IndexedRunOutcome.DONE), "The next run would fail all the same, and the one after it, without end.");
             Assert.That(statuses[^1].State, Is.EqualTo(DataSourceEmbeddingState.FAILED), "The run is over, so its row has to say so, and why.");
             Assert.That(statuses[^1].LastError, Is.EqualTo("The embedding provider cannot be reached."));
             Assert.That(manifest.SourceHash, Is.Empty, "A run which stopped halfway did not get through the folder.");
-        });
+        }
     }
 
     [Test]
@@ -191,11 +191,11 @@ public sealed class DocumentRunProgressTests
         await progress.RecordDocumentFailureAsync(Document("/tmp/test-data/b.pdf"), new ProviderRequestException(ProviderRequestFailureReason.TOO_MANY_REQUESTS, "Too many requests."), CancellationToken.None);
         var outcome = await progress.PauseRunAsync(null, "test", CancellationToken.None);
 
-        Assert.Multiple(() =>
+        using (Assert.EnterMultipleScope())
         {
             Assert.That(outcome, Is.EqualTo(IndexedRunOutcome.MORE_TO_DO), "The pass skips both documents from now on, so the next step gets further. Ending here left every file behind a block of failing files unindexed.");
             Assert.That(statuses.Select(status => status.State), Has.None.EqualTo(DataSourceEmbeddingState.FAILED));
-        });
+        }
     }
 
     [Test]
@@ -207,11 +207,11 @@ public sealed class DocumentRunProgressTests
         await progress.RecordDocumentFailureAsync(Document("/tmp/test-data/scan.pdf"), new FileExtractionException(FileExtractionErrorCode.NO_TEXT_EXTRACTED, "No text."), CancellationToken.None);
         var outcome = await progress.PauseRunAsync(null, "test", CancellationToken.None);
 
-        Assert.Multiple(() =>
+        using (Assert.EnterMultipleScope())
         {
             Assert.That(outcome, Is.EqualTo(IndexedRunOutcome.MORE_TO_DO), "A locked subfolder fails in every run, however much the run gets done otherwise, and the scanned document is never read again. Ending here left the rest of the folder unindexed.");
             Assert.That(statuses.Select(status => status.State), Has.None.EqualTo(DataSourceEmbeddingState.FAILED));
-        });
+        }
     }
 
     [Test]
@@ -223,12 +223,12 @@ public sealed class DocumentRunProgressTests
         var shortlyBefore = progress.HasDoneItsShare(NOW + TimeSpan.FromMinutes(5) - TimeSpan.FromSeconds(1));
         var atTheEnd = progress.HasDoneItsShare(NOW + TimeSpan.FromMinutes(5));
 
-        Assert.Multiple(() =>
+        using (Assert.EnterMultipleScope())
         {
             Assert.That(first, Is.False, "However long finding the documents took, every run reads at least one. Otherwise, a folder whose files take longer to list than the share would never get anywhere.");
             Assert.That(shortlyBefore, Is.False);
             Assert.That(atTheEnd, Is.True);
-        });
+        }
     }
 
     [Test]
@@ -243,11 +243,11 @@ public sealed class DocumentRunProgressTests
         await progress.RecordDocumentFailureAsync(Document("/tmp/test-data/scan.pdf"), new FileExtractionException(FileExtractionErrorCode.NO_TEXT_EXTRACTED, "No text."), CancellationToken.None);
         var afterThree = progress.HasDoneItsShare(NOW);
 
-        Assert.Multiple(() =>
+        using (Assert.EnterMultipleScope())
         {
             Assert.That(afterTwo, Is.False);
             Assert.That(afterThree, Is.True, "Reading a document costs its time, whether indexing it worked or not.");
-        });
+        }
     }
 
     [Test]
@@ -272,13 +272,13 @@ public sealed class DocumentRunProgressTests
         var skipped = nextStep.SkipIfFailedEarlierInPass("/tmp/test-data/report.pdf", "FINGERPRINT");
         nextStep.Publish();
 
-        Assert.Multiple(() =>
+        using (Assert.EnterMultipleScope())
         {
             Assert.That(skipped, Is.True, "Reading it once more costs time, with a cloud provider money as well, and ends the same way.");
             Assert.That(statuses[^1].FailedDocuments, Is.EqualTo(1));
             Assert.That(statuses[^1].Failures.Select(failure => failure.DocumentKey), Is.EquivalentTo(["/tmp/test-data/report.pdf"]), "The list lost the failures of every earlier step.");
             Assert.That(statuses[^1].LastError, Is.Not.Empty);
-        });
+        }
     }
 
     [Test]
@@ -340,11 +340,11 @@ public sealed class DocumentRunProgressTests
             var (nextPass, _, _) = CreateProgress(totalDocuments: 10, pass: NewPass());
             await nextPass.RecordDocumentFailureAsync(Document("/tmp/test-data/a.pdf"), new ProviderRequestException(ProviderRequestFailureReason.TOO_MANY_REQUESTS, message), CancellationToken.None);
 
-            Assert.Multiple(() =>
+            using (Assert.EnterMultipleScope())
             {
                 Assert.That(reportedDuringThePass, Is.EqualTo(1), "A rate limit which lasts showed a message every five minutes.");
                 Assert.That(collector.Count, Is.EqualTo(2), "A new pass is a new attempt, which the user hears about should it fail again.");
-            });
+            }
         }
         finally
         {
@@ -373,13 +373,13 @@ public sealed class DocumentRunProgressTests
 
         progress.PublishRunFailure("This sync would remove 250 mails.", DataSourceAttention.MASS_REMOVAL_PENDING, 250);
 
-        Assert.Multiple(() =>
+        using (Assert.EnterMultipleScope())
         {
             Assert.That(statuses[^1].State, Is.EqualTo(DataSourceEmbeddingState.FAILED));
             Assert.That(statuses[^1].Attention, Is.EqualTo(DataSourceAttention.MASS_REMOVAL_PENDING));
             Assert.That(statuses[^1].PendingRemovalCount, Is.EqualTo(250), "Agreeing hands back the very number the user was shown.");
             Assert.That(statuses[^1].LastError, Is.EqualTo("This sync would remove 250 mails."));
-        });
+        }
     }
 
     [Test]
@@ -413,7 +413,7 @@ public sealed class DocumentRunProgressTests
         progress.Publish();
         progress.PublishStoredState(workedThrough: true);
 
-        Assert.Multiple(() =>
+        using (Assert.EnterMultipleScope())
         {
             Assert.That(statuses, Has.Count.EqualTo(2));
             Assert.That(statuses.All(status => status.IgnoredFiles.SequenceEqual(ignoredFiles)), Is.True);
@@ -421,7 +421,7 @@ public sealed class DocumentRunProgressTests
             Assert.That(statuses.All(status => status.ExcludedFolders.SequenceEqual(excludedFolders)), Is.True);
             Assert.That(statuses.All(status => status.SkippedDocuments == ignoredFiles.Length), Is.True, "Excluded folders are intentional and count as nothing skipped.");
             Assert.That(statuses.All(status => status.ProgressPercent == 100), Is.True);
-        });
+        }
     }
 
     [Test]
@@ -434,12 +434,12 @@ public sealed class DocumentRunProgressTests
         await progress.RecordDocumentFailureAsync(mail, new IOException("The vector store refused the chunks."), CancellationToken.None);
         await progress.CompleteRunAsync("SOURCE-HASH", "test", CancellationToken.None);
 
-        Assert.Multiple(() =>
+        using (Assert.EnterMultipleScope())
         {
             Assert.That(statuses[^1].Failures[0].DisplayName, Is.EqualTo("Board report due today"), "The key of a mail is a hash, which tells the user nothing.");
             Assert.That(statuses[^1].Failures[0].Reason, Does.Contain("'Board report due today'").And.Not.Contain("file"), "A mail was called a file.");
             Assert.That(statuses[^1].LastError, Does.Not.Contain("file"));
-        });
+        }
     }
 
     [Test]