Sorted every model list by what a model is made for (#984)

app/MindWork AI Studio/Dialogs/EmbeddingProviderDialog.razor

@@ -85,48 +85,42 @@
 
             <MudField FullWidth="true" Label="@T("Model selection")" Variant="Variant.Outlined" Class="mb-3">
                 <MudStack Row="@true" AlignItems="AlignItems.Center" StretchItems="StretchItems.End">
-                    @if (this.DataLLMProvider.IsEmbeddingModelProvidedManually(this.DataHost))
+                    <MudButton Disabled="@(this.IsEnterpriseConfiguration || !this.DataLLMProvider.CanLoadModels(this.DataHost, this.dataAPIKey))" Variant="Variant.Filled" Size="Size.Small" StartIcon="@Icons.Material.Filled.Refresh" OnClick="@this.ReloadModels">
+                        @T("Load")
+                    </MudButton>
+                    @if (this.availableModels.Count is 0)
                     {
-                        <MudTextField
-                            T="string"
-                            @bind-Text="@this.dataManuallyModel"
-                            Label="@T("Model")"
-                            Class="mb-3"
-                            Adornment="Adornment.Start"
-                            AdornmentIcon="@Icons.Material.Filled.Dns"
-                            AdornmentColor="Color.Info"
-                            Disabled="@this.IsEnterpriseConfiguration"
-                            Validation="@this.ValidateManuallyModel"
-                            UserAttributes="@SPELLCHECK_ATTRIBUTES"
-                            HelperText="@T("Currently, we cannot query the embedding models for the selected provider and/or host. Therefore, please enter the model name manually.")"/>
+                        <MudText Typo="Typo.body1">
+                            @T("No models loaded or available.")
+                        </MudText>
                     }
                     else
                     {
-                        <MudButton Disabled="@(this.IsEnterpriseConfiguration || !this.DataLLMProvider.CanLoadModels(this.DataHost, this.dataAPIKey))" Variant="Variant.Filled" Size="Size.Small" StartIcon="@Icons.Material.Filled.Refresh" OnClick="@this.ReloadModels">
-                            @T("Load")
-                        </MudButton>
-                        @if (this.availableModels.Count is 0)
-                        {
-                            <MudText Typo="Typo.body1">
-                                @T("No models loaded or available.")
-                            </MudText>
-                        }
-                        else
-                        {
-                            <MudSelect Disabled="@(this.IsEnterpriseConfiguration || this.IsNoneProvider)" @bind-Value="@this.DataModel" Label="@T("Model")"
-                                       OpenIcon="@Icons.Material.Filled.FaceRetouchingNatural"
-                                       AdornmentColor="Color.Info" Adornment="Adornment.Start"
-                                       Validation="@this.providerValidation.ValidatingModel">
-                                @foreach (var model in this.availableModels)
-                                {
-                                    <MudSelectItem Value="@model">
-                                        @model
-                                    </MudSelectItem>
-                                }
-                            </MudSelect>
-                        }
+                        <MudSelect Disabled="@(this.IsEnterpriseConfiguration || this.IsNoneProvider)" @bind-Value="@this.DataModel" Label="@T("Model")"
+                                   OpenIcon="@Icons.Material.Filled.FaceRetouchingNatural"
+                                   AdornmentColor="Color.Info" Adornment="Adornment.Start"
+                                   Validation="@this.providerValidation.ValidatingModel">
+                            @foreach (var model in this.availableModels)
+                            {
+                                <MudSelectItem Value="@model">
+                                    @model
+                                </MudSelectItem>
+                            }
+                        </MudSelect>
                     }
                 </MudStack>
+                @if (this.dataConfiguredModelIsNotOffered)
+                {
+                    <MudAlert Severity="Severity.Info" Class="mt-3">
+                        @T("This server does not offer the selected model right now. It stays selected, so the documents you already prepared keep working. Choosing another model means every document of the data sources behind this provider is prepared again.")
+                    </MudAlert>
+                }
+                @if (this.ServerNamedNoEmbeddingModel)
+                {
+                    <MudAlert Severity="Severity.Info" Class="mt-3">
+                        @T("Your server answered, but none of the models it serves is one we know to create embeddings. Either there is none installed, or it runs under a name we do not recognize. In the latter case, your organization can describe the model in a model plugin, and it will show up here.")
+                    </MudAlert>
+                }
                 @if (!string.IsNullOrWhiteSpace(this.dataLoadingModelsIssue))
                 {
                     <MudAlert Severity="Severity.Error" Class="mt-3">

app/MindWork AI Studio/Dialogs/EmbeddingProviderDialog.razor.cs

@@ -133,10 +133,11 @@ public partial class EmbeddingProviderDialog : MSGComponentBase, ISecretId
     private string[] dataIssues = [];
     private string dataAPIKey = string.Empty;
     private bool dataHadStoredAPIKeyOnLoad;
-    private string dataManuallyModel = string.Empty;
     private string dataAPIKeyStorageIssue = string.Empty;
     private string dataEditingPreviousInstanceName = string.Empty;
     private string dataLoadingModelsIssue = string.Empty;
+    private bool dataConfiguredModelIsNotOffered;
+    private bool dataServerWasAskedForItsModels;
     private string dataFilePath = string.Empty;
     private string dataTokenizerFingerprint = string.Empty;
     private string dataCustomTokenizerValidationIssue = string.Empty;
@@ -162,7 +163,6 @@ public partial class EmbeddingProviderDialog : MSGComponentBase, ISecretId
             GetPreviousInstanceName = () => this.dataEditingPreviousInstanceName,
             GetUsedInstanceNames = () => this.UsedInstanceNames,
             GetHost = () => this.DataHost,
-            IsModelProvidedManually = () => this.DataLLMProvider.IsEmbeddingModelProvidedManually(this.DataHost),
             GetCustomTokenizerValidationIssue = () => this.dataCustomTokenizerValidationIssue,
         };
     }
@@ -170,24 +170,13 @@ public partial class EmbeddingProviderDialog : MSGComponentBase, ISecretId
     private EmbeddingProvider CreateEmbeddingProviderSettings()
     {
         var cleanedHostname = this.DataHostname.Trim();
-        Model model = default;
-        if(this.DataLLMProvider is LLMProviders.SELF_HOSTED)
-        {
-            if (this.DataLLMProvider.IsEmbeddingModelProvidedManually(this.DataHost))
-                model = new Model(this.dataManuallyModel, null);
-            else if (this.DataHost is Host.LM_STUDIO)
-                model = this.DataModel;
-        }
-        else
-            model = this.DataModel;
-        
         return new()
         {
             Num = this.DataNum,
             Id = this.DataId,
             Name = this.DataName,
             UsedLLMProvider = this.DataLLMProvider,
-            Model = model,
+            Model = this.DataModel,
             IsSelfHosted = this.DataLLMProvider is LLMProviders.SELF_HOSTED,
             Hostname = cleanedHostname.EndsWith('/') ? cleanedHostname[..^1] : cleanedHostname,
             Host = this.DataHost,
@@ -225,10 +214,6 @@ public partial class EmbeddingProviderDialog : MSGComponentBase, ISecretId
                                       || this.DataTokenLimit != EmbeddingProvider.DEFAULT_TOKEN_LIMIT
                                       || this.DataEmbeddingBatchSize != EmbeddingProvider.DEFAULT_EMBEDDING_BATCH_SIZE;
             
-            // When using self-hosted embedding, we must copy the model name:
-            if (this.DataLLMProvider is LLMProviders.SELF_HOSTED)
-                this.dataManuallyModel = this.DataModel.Id;
-            
             // Load the API key. A self-hosted server may well need one: LM Studio can ask for a
             // token of its own, and any of these servers can sit behind an authenticating proxy.
             // So we try for every host and treat a missing key as the normal case (isTrying).
@@ -358,14 +343,6 @@ public partial class EmbeddingProviderDialog : MSGComponentBase, ISecretId
         this.MudDialog.Close(DialogResult.Ok(addedProviderSettings));
     }
     
-    private string? ValidateManuallyModel(string manuallyModel)
-    {
-        if (this.DataLLMProvider is LLMProviders.SELF_HOSTED && string.IsNullOrWhiteSpace(manuallyModel))
-            return T("Please enter an embedding model name.");
-        
-        return null;
-    }
-
     private string? ValidateTokenLimit(int tokenLimit)
     {
         if (tokenLimit < 1)
@@ -516,9 +493,9 @@ public partial class EmbeddingProviderDialog : MSGComponentBase, ISecretId
         // When the host changes, reset the model selection state:
         this.DataHost = selectedHost;
         this.DataModel = default;
-        this.dataManuallyModel = string.Empty;
         this.availableModels.Clear();
         this.dataLoadingModelsIssue = string.Empty;
+        this.dataConfiguredModelIsNotOffered = false;
     }
 
     /// <summary>
@@ -535,11 +512,13 @@ public partial class EmbeddingProviderDialog : MSGComponentBase, ISecretId
         this.DataModel = default;
         this.availableModels.Clear();
         this.dataLoadingModelsIssue = string.Empty;
+        this.dataConfiguredModelIsNotOffered = false;
     }
 
     private async Task ReloadModels()
     {
         this.dataLoadingModelsIssue = string.Empty;
+        this.dataServerWasAskedForItsModels = true;
         var currentEmbeddingProviderSettings = this.CreateEmbeddingProviderSettings();
         var provider = currentEmbeddingProviderSettings.CreateProvider();
         if (provider is NoProvider)
@@ -562,8 +541,57 @@ public partial class EmbeddingProviderDialog : MSGComponentBase, ISecretId
             this.Logger.LogError($"Failed to load models from provider '{this.DataLLMProvider}' (host={this.DataHost}, hostname='{this.DataHostname}'): {e.Message}");
             this.dataLoadingModelsIssue = T("We are currently unable to communicate with the provider to load models. Please try again later.");
         }
+
+        // Whatever the server answered, and whether it answered at all, the model this provider was
+        // configured with stays on the list:
+        this.PinConfiguredModel();
     }
-    
+
+    /// <summary>
+    /// Keeps the configured model selectable, also when the server does not offer it right now.
+    /// </summary>
+    /// <remarks>
+    /// This is deliberately the opposite of what the chat provider dialog does, which replaces the
+    /// configured model with the one the server reported. An embedding provider carries indexed data
+    /// sources, and its model ID is part of the embedding signature: changing it -- even only in its
+    /// spelling -- means every prepared document is prepared again. So the stored model is added to
+    /// the list here rather than the list being applied to the stored model. A model nobody serves
+    /// any more stays visible and stays chosen, and changing it stays the user's decision, which
+    /// storing then asks about.
+    ///
+    /// Comparing is what Model does, which is by ID and ordinal. Matching a differing spelling would
+    /// mean writing that other spelling into the settings, and that is the very change this avoids.
+    /// </remarks>
+    private void PinConfiguredModel()
+    {
+        if (string.IsNullOrWhiteSpace(this.DataModel.Id))
+        {
+            this.dataConfiguredModelIsNotOffered = false;
+            return;
+        }
+
+        this.dataConfiguredModelIsNotOffered = !this.availableModels.Contains(this.DataModel);
+        if (this.dataConfiguredModelIsNotOffered)
+            this.availableModels.Insert(0, this.DataModel);
+    }
+
+    /// <summary>
+    /// Whether the server answered without naming a single embedding model.
+    /// </summary>
+    /// <remarks>
+    /// Two situations end up here, and the user is the only one who can tell them apart: a server
+    /// running no embedding model at all, and one running an embedding model under a name no rule
+    /// covers. Saying so beats the bare "No models loaded or available.", which reads like a
+    /// failure and leaves nobody anywhere to go -- the field for typing a name is gone, on purpose.
+    /// Describing such a model in a model plugin is the way out, and naming it here is what turns
+    /// a dead end into one.
+    /// </remarks>
+    private bool ServerNamedNoEmbeddingModel =>
+        this.DataLLMProvider is LLMProviders.SELF_HOSTED &&
+        this.dataServerWasAskedForItsModels &&
+        string.IsNullOrWhiteSpace(this.dataLoadingModelsIssue) &&
+        this.availableModels.Count is 0;
+
     private string APIKeyText => this.DataLLMProvider switch
     {
         LLMProviders.SELF_HOSTED => T("(Optional) API Key"),

app/MindWork AI Studio/Dialogs/TranscriptionProviderDialog.razor

@@ -87,47 +87,28 @@
             {
                 <MudField FullWidth="true" Label="@T("Model selection")" Variant="Variant.Outlined" Class="mb-3">
                     <MudStack Row="@true" AlignItems="AlignItems.Center" StretchItems="StretchItems.End">
-                        @if (this.DataLLMProvider.IsTranscriptionModelProvidedManually(this.DataHost))
+                        <MudButton Disabled="@(this.IsEnterpriseConfiguration || !this.DataLLMProvider.CanLoadModels(this.DataHost, this.dataAPIKey))" Variant="Variant.Filled" Size="Size.Small" StartIcon="@Icons.Material.Filled.Refresh" OnClick="@this.ReloadModels">
+                            @T("Load")
+                        </MudButton>
+                        @if(this.availableModels.Count is 0)
                         {
-                            <MudTextField
-                                T="string"
-                                @bind-Text="@this.dataManuallyModel"
-                                Label="@T("Model")"
-                                Class="mb-3"
-                                Adornment="Adornment.Start"
-                                AdornmentIcon="@Icons.Material.Filled.Dns"
-                                AdornmentColor="Color.Info"
-                                Disabled="@this.IsEnterpriseConfiguration"
-                                Validation="@this.ValidateManuallyModel"
-                                UserAttributes="@SPELLCHECK_ATTRIBUTES"
-                                HelperText="@T("Currently, we cannot query the transcription models for the selected provider and/or host. Therefore, please enter the model name manually.")"
-                            />
+                            <MudText Typo="Typo.body1">
+                                @T("No models loaded or available.")
+                            </MudText>
                         }
                         else
                         {
-                            <MudButton Disabled="@(this.IsEnterpriseConfiguration || !this.DataLLMProvider.CanLoadModels(this.DataHost, this.dataAPIKey))" Variant="Variant.Filled" Size="Size.Small" StartIcon="@Icons.Material.Filled.Refresh" OnClick="@this.ReloadModels">
-                                @T("Load")
-                            </MudButton>
-                            @if(this.availableModels.Count is 0)
-                            {
-                                <MudText Typo="Typo.body1">
-                                    @T("No models loaded or available.")
-                                </MudText>
-                            }
-                            else
-                            {
-                                <MudSelect Disabled="@(this.IsEnterpriseConfiguration || this.IsNoneProvider)" @bind-Value="@this.DataModel" Label="@T("Model")"
-                                           OpenIcon="@Icons.Material.Filled.FaceRetouchingNatural"
-                                           AdornmentColor="Color.Info" Adornment="Adornment.Start"
-                                           Validation="@this.providerValidation.ValidatingModel">
-                                    @foreach (var model in this.availableModels)
-                                    {
-                                        <MudSelectItem Value="@model">
-                                            @model
-                                        </MudSelectItem>
-                                    }
-                                </MudSelect>
-                            }
+                            <MudSelect Disabled="@(this.IsEnterpriseConfiguration || this.IsNoneProvider)" @bind-Value="@this.DataModel" Label="@T("Model")"
+                                       OpenIcon="@Icons.Material.Filled.FaceRetouchingNatural"
+                                       AdornmentColor="Color.Info" Adornment="Adornment.Start"
+                                       Validation="@this.providerValidation.ValidatingModel">
+                                @foreach (var model in this.availableModels)
+                                {
+                                    <MudSelectItem Value="@model">
+                                        @model
+                                    </MudSelectItem>
+                                }
+                            </MudSelect>
                         }
                     </MudStack>
                     @if (!string.IsNullOrWhiteSpace(this.dataLoadingModelsIssue))

app/MindWork AI Studio/Dialogs/TranscriptionProviderDialog.razor.cs

@@ -106,7 +106,6 @@ public partial class TranscriptionProviderDialog : MSGComponentBase, ISecretId
     private string[] dataIssues = [];
     private string dataAPIKey = string.Empty;
     private bool dataHadStoredAPIKeyOnLoad;
-    private string dataManuallyModel = string.Empty;
     private string dataAPIKeyStorageIssue = string.Empty;
     private string dataEditingPreviousInstanceName = string.Empty;
     private string dataLoadingModelsIssue = string.Empty;
@@ -127,7 +126,6 @@ public partial class TranscriptionProviderDialog : MSGComponentBase, ISecretId
             GetPreviousInstanceName = () => this.dataEditingPreviousInstanceName,
             GetUsedInstanceNames = () => this.UsedInstanceNames,
             GetHost = () => this.DataHost,
-            IsModelProvidedManually = () => this.DataLLMProvider.IsTranscriptionModelProvidedManually(this.DataHost),
         };
     }
     
@@ -135,30 +133,9 @@ public partial class TranscriptionProviderDialog : MSGComponentBase, ISecretId
     {
         var cleanedHostname = this.DataHostname.Trim();
 
-        // Determine the model based on the provider and host configuration:
-        Model model;
-        if (this.DataLLMProvider.IsTranscriptionModelSelectionHidden(this.DataHost))
-        {
-            // Use system model placeholder for hosts that don't support model selection (e.g., whisper.cpp):
-            model = Model.SYSTEM_MODEL;
-        }
-        else if (this.DataLLMProvider is LLMProviders.SELF_HOSTED)
-        {
-            switch (this.DataHost)
-            {
-                case Host.OLLAMA:
-                    model = new Model(this.dataManuallyModel, null);
-                    break;
-
-                case Host.VLLM:
-                case Host.LM_STUDIO:
-                default:
-                    model = this.DataModel;
-                    break;
-            }
-        }
-        else
-            model = this.DataModel;
+        // whisper.cpp serves whatever it was started with and names no models, so the placeholder
+        // stands in for the one model there is. Everywhere else the user picked one from the list:
+        var model = this.DataLLMProvider.IsTranscriptionModelSelectionHidden(this.DataHost) ? Model.SYSTEM_MODEL : this.DataModel;
 
         return new()
         {
@@ -194,10 +171,6 @@ public partial class TranscriptionProviderDialog : MSGComponentBase, ISecretId
         if(this.IsEditing)
         {
             this.dataEditingPreviousInstanceName = this.DataName.ToLowerInvariant();
-            
-            // When using self-hosted models, we must copy the model name:
-            if (this.DataLLMProvider is LLMProviders.SELF_HOSTED)
-                this.dataManuallyModel = this.DataModel.Id;
 
             // Load the API key. A self-hosted server may well need one: LM Studio can ask for a
             // token of its own, and any of these servers can sit behind an authenticating proxy.
@@ -302,14 +275,6 @@ public partial class TranscriptionProviderDialog : MSGComponentBase, ISecretId
         this.MudDialog.Close(DialogResult.Ok(addedProviderSettings));
     }
     
-    private string? ValidateManuallyModel(string manuallyModel)
-    {
-        if (this.DataLLMProvider is LLMProviders.SELF_HOSTED && string.IsNullOrWhiteSpace(manuallyModel))
-            return T("Please enter a transcription model name.");
-
-        return null;
-    }
-
     private void Cancel() => this.MudDialog.Cancel();
 
     private async Task OnAPIKeyChanged(string apiKey)
@@ -327,7 +292,6 @@ public partial class TranscriptionProviderDialog : MSGComponentBase, ISecretId
         // When the host changes, reset the model selection state:
         this.DataHost = selectedHost;
         this.DataModel = default;
-        this.dataManuallyModel = string.Empty;
         this.availableModels.Clear();
         this.dataLoadingModelsIssue = string.Empty;
     }