Turned getter-like extension methods into extension properties (#1157)

app/MindWork AI Studio/Provider/HuggingFace/HFInferenceProviderExtensions.cs

@@ -12,8 +12,8 @@ public static class HFInferenceProviderExtensions
         /// <summary>
         /// The slug Hugging Face uses for this inference provider.
         /// </summary>
-        /// <returns>The slug, or an empty string for the routing strategies, which name no provider.</returns>
-        public string EndpointsId() => provider switch
+        /// <value>The slug, or an empty string for the routing strategies, which name no provider.</value>
+        public string EndpointsId => provider switch
         {
             HFInferenceProvider.BASETEN => "baseten",
             HFInferenceProvider.CEREBRAS => "cerebras",
@@ -41,22 +41,22 @@ public static class HFInferenceProviderExtensions
         /// a suffix on the model name, e.g. "google/gemma-4-31B-it:novita". Without a suffix, the router
         /// picks the fastest provider itself.
         /// </remarks>
-        /// <returns>The suffix including its colon, or an empty string when the router should choose.</returns>
-        public string ModelSuffix() => provider switch
+        /// <value>The suffix including its colon, or an empty string when the router should choose.</value>
+        public string ModelSuffix => provider switch
         {
             HFInferenceProvider.NONE or HFInferenceProvider.AUTOMATIC => string.Empty,
 
             HFInferenceProvider.CHEAPEST => ":cheapest",
             HFInferenceProvider.PREFERRED => ":preferred",
 
-            _ => $":{provider.EndpointsId()}",
+            _ => $":{provider.EndpointsId}",
         };
 
         /// <summary>
         /// Whether this inference provider serves models to chat with.
         /// </summary>
-        /// <returns>True, when the provider serves chat models.</returns>
-        public bool SupportsChat() => provider is not HFInferenceProvider.NONE;
+        /// <value>True, when the provider serves chat models.</value>
+        public bool SupportsChat => provider is not HFInferenceProvider.NONE;
 
         /// <summary>
         /// Whether this inference provider creates embeddings for us.
@@ -67,8 +67,8 @@ public static class HFInferenceProviderExtensions
         /// OpenAI-compatible form we send. The routing strategies are out by their nature: without a
         /// named provider there is no route to address.
         /// </remarks>
-        /// <returns>True, when we can create embeddings through this provider.</returns>
-        public bool SupportsEmbeddings() => provider is HFInferenceProvider.TOGETHER_AI or HFInferenceProvider.DEEPINFRA;
+        /// <value>True, when we can create embeddings through this provider.</value>
+        public bool SupportsEmbeddings => provider is HFInferenceProvider.TOGETHER_AI or HFInferenceProvider.DEEPINFRA;
 
         /// <summary>
         /// Whether this inference provider transcribes audio for us.
@@ -79,8 +79,8 @@ public static class HFInferenceProviderExtensions
         /// transcribe for Hugging Face, but not in a shape we could send an audio file to: fal-ai and
         /// Replicate both turn the request down with "Model not supported by provider".
         /// </remarks>
-        /// <returns>True, when we can transcribe audio through this provider.</returns>
-        public bool SupportsTranscription() => provider is HFInferenceProvider.TOGETHER_AI or HFInferenceProvider.DEEPINFRA;
+        /// <value>True, when we can transcribe audio through this provider.</value>
+        public bool SupportsTranscription => provider is HFInferenceProvider.TOGETHER_AI or HFInferenceProvider.DEEPINFRA;
 
         /// <summary>
         /// The base URL of the provider's own OpenAI-compatible route.
@@ -91,8 +91,8 @@ public static class HFInferenceProviderExtensions
         /// keeps it below an additional "openai" segment, and answers the path without it with
         /// "Not allowed to POST /v1/embeddings for provider deepinfra".
         /// </remarks>
-        /// <returns>The base URL, or an empty string when the provider has no such route.</returns>
-        public string ProviderBaseURL() => provider switch
+        /// <value>The base URL, or an empty string when the provider has no such route.</value>
+        public string ProviderBaseURL => provider switch
         {
             HFInferenceProvider.TOGETHER_AI => "https://router.huggingface.co/together/v1/",
             HFInferenceProvider.DEEPINFRA => "https://router.huggingface.co/deepinfra/v1/openai/",
@@ -103,14 +103,17 @@ public static class HFInferenceProviderExtensions
         /// <summary>
         /// The value to filter the Hugging Face model catalog by.
         /// </summary>
-        /// <returns>The provider slug, or "all" when no particular provider was chosen.</returns>
-        public string CatalogFilter()
+        /// <value>The provider slug, or "all" when no particular provider was chosen.</value>
+        public string CatalogFilter
         {
-            var slug = provider.EndpointsId();
-            return string.IsNullOrEmpty(slug) ? "all" : slug;
+            get
+            {
+                var slug = provider.EndpointsId;
+                return string.IsNullOrEmpty(slug) ? "all" : slug;
+            }
         }
 
-        public string ToName() => provider switch
+        public string Name => provider switch
         {
             HFInferenceProvider.AUTOMATIC => TB("Automatic: the fastest provider"),
             HFInferenceProvider.CHEAPEST => TB("Automatic: the cheapest provider"),

app/MindWork AI Studio/Provider/HuggingFace/ProviderHuggingFace.cs

@@ -64,7 +64,7 @@ public sealed class ProviderHuggingFace : BaseProvider
         if (endpointKind is HFEndpointKind.CHAT)
             return ROUTER_BASE_URL;
 
-        var providerBaseURL = hfProvider.ProviderBaseURL();
+        var providerBaseURL = hfProvider.ProviderBaseURL;
         return string.IsNullOrEmpty(providerBaseURL) ? ROUTER_BASE_URL : providerBaseURL;
     }
 
@@ -83,7 +83,7 @@ public sealed class ProviderHuggingFace : BaseProvider
         if (string.IsNullOrWhiteSpace(modelId) || modelId.Contains(':'))
             return modelId;
 
-        return $"{modelId}{this.hfProvider.ModelSuffix()}";
+        return $"{modelId}{this.hfProvider.ModelSuffix}";
     }
 
     /// <summary>
@@ -141,7 +141,7 @@ public sealed class ProviderHuggingFace : BaseProvider
         if (this.hfProvider is HFInferenceProvider.NONE or HFInferenceProvider.AUTOMATIC or HFInferenceProvider.CHEAPEST or HFInferenceProvider.PREFERRED)
             return TB("No Hugging Face inference provider offers the selected model. Please check the model name and whether it is still available on Hugging Face.");
 
-        return string.Format(TB("The Hugging Face inference provider '{0}' does not offer the selected model. Please select another inference provider, or let Hugging Face choose one for you."), this.hfProvider.ToName());
+        return string.Format(TB("The Hugging Face inference provider '{0}' does not offer the selected model. Please select another inference provider, or let Hugging Face choose one for you."), this.hfProvider.Name);
     }
 
     #endregion
@@ -149,7 +149,7 @@ public sealed class ProviderHuggingFace : BaseProvider
     #region Implementation of IProvider
 
     /// <inheritdoc />
-    public override string Id => LLMProviders.HUGGINGFACE.ToSecretId();
+    public override string Id => LLMProviders.HUGGINGFACE.SecretId;
 
     /// <inheritdoc />
     public override string InstanceName { get; set; } = "HuggingFace";
@@ -247,7 +247,7 @@ public sealed class ProviderHuggingFace : BaseProvider
     /// <returns>One listing per model, which says nothing for the models nobody stated a window for.</returns>
     private IEnumerable<ModelListing> ListingsOf(ModelsResponse response)
     {
-        var providerSlug = this.hfProvider.EndpointsId();
+        var providerSlug = this.hfProvider.EndpointsId;
         return response.Data.Select(hfModel => ModelListing.For(hfModel.Id, hfModel.ContextWindowTokens(providerSlug)));
     }
 
@@ -265,7 +265,7 @@ public sealed class ProviderHuggingFace : BaseProvider
     private IEnumerable<Model> SelectChatModels(ModelsResponse response)
     {
         var chatModels = response.Data.Where(hfModel => new Model(hfModel.Id, null).IsChatModel(this.Provider));
-        var providerSlug = this.hfProvider.EndpointsId();
+        var providerSlug = this.hfProvider.EndpointsId;
         if (string.IsNullOrEmpty(providerSlug))
             return ToModels(chatModels);
 
@@ -293,7 +293,7 @@ public sealed class ProviderHuggingFace : BaseProvider
     /// <inheritdoc />
     public override Task<ModelLoadResult> GetEmbeddingModels(string? apiKeyProvisional = null, CancellationToken token = default)
     {
-        if (!this.hfProvider.SupportsEmbeddings())
+        if (!this.hfProvider.SupportsEmbeddings)
             return Task.FromResult(ModelLoadResult.FromModels([]));
 
         return this.LoadHubModels(SecretStoreType.EMBEDDING_PROVIDER, "feature-extraction", apiKeyProvisional, token);
@@ -309,14 +309,14 @@ public sealed class ProviderHuggingFace : BaseProvider
     /// <returns>The models of that provider for that task.</returns>
     private Task<ModelLoadResult> LoadHubModels(SecretStoreType storeType, string pipelineTag, string? apiKeyProvisional, CancellationToken token)
     {
-        var requestURL = $"{HUB_MODELS_URL}{this.hfProvider.EndpointsId()}&pipeline_tag={pipelineTag}";
+        var requestURL = $"{HUB_MODELS_URL}{this.hfProvider.EndpointsId}&pipeline_tag={pipelineTag}";
         return this.LoadModelsResponse<IList<HubModel>>(storeType, requestURL, hubModels => hubModels.Select(hubModel => new Model(hubModel.Id, null)), apiKeyProvisional, token: token);
     }
     
     /// <inheritdoc />
     public override Task<ModelLoadResult> GetTranscriptionModels(string? apiKeyProvisional = null, CancellationToken token = default)
     {
-        if (!this.hfProvider.SupportsTranscription())
+        if (!this.hfProvider.SupportsTranscription)
             return Task.FromResult(ModelLoadResult.FromModels([]));
 
         return this.LoadHubModels(SecretStoreType.TRANSCRIPTION_PROVIDER, "automatic-speech-recognition", apiKeyProvisional, token);