Removed provider access rule suppressions outside the settings manager (#915)

app/MindWork AI Studio/Components/ConfigurationProviderSelection.razor.cs

@@ -1,5 +1,3 @@
-using System.Diagnostics.CodeAnalysis;
-
 using AIStudio.Provider;
 using AIStudio.Settings;
 using AIStudio.Tools.PluginSystem;
@@ -35,27 +33,20 @@ public partial class ConfigurationProviderSelection : MSGComponentBase
     [Parameter]
     public Func<bool> IsLocked { get; set; } = () => false;
     
-    [SuppressMessage("Usage", "MWAIS0001:Direct access to `Providers` is not allowed")]
     private IEnumerable<ConfigurationSelectData<string>> FilteredData()
     {
         if(this.Component is not Tools.Components.NONE and not Tools.Components.APP_SETTINGS)
             yield return new(T("Use app default"), string.Empty);
-        
-        // Get the minimum confidence level for this component, and/or the enforced global minimum confidence level:
-        var minimumLevel = this.SettingsManager.GetMinimumConfidenceLevel(this.Component);
-        
-        // Apply the explicit minimum confidence level if set and higher than the current minimum level:
-        if (this.ExplicitMinimumConfidence is not ConfidenceLevel.UNKNOWN && this.ExplicitMinimumConfidence > minimumLevel)
-            minimumLevel = this.ExplicitMinimumConfidence;
-        
-        // Filter the providers based on the minimum confidence level:
+
+        //
+        // Filter the providers based on the minimum confidence level of this component, the enforced
+        // global minimum, and the explicit minimum level when it is higher. Providers which no longer
+        // exist resolve to `Provider.NONE` and are dropped by the confidence check as well:
+        //
         foreach (var providerId in this.Data)
         {
-            var provider = this.SettingsManager.ConfigurationData.Providers.FirstOrDefault(x => x.Id == providerId.Value);
-            if (provider is null)
-                continue;
-            
-            if (provider.UsedLLMProvider.GetConfidence(this.SettingsManager).Level >= minimumLevel)
+            var provider = this.SettingsManager.GetProviderById(providerId.Value);
+            if (this.SettingsManager.IsProviderConfident(provider, this.Component, this.ExplicitMinimumConfidence))
                 yield return providerId;
         }
     }

app/MindWork AI Studio/Components/ProviderSelection.razor.cs

@@ -1,5 +1,3 @@
-using System.Diagnostics.CodeAnalysis;
-
 using AIStudio.Provider;
 using AIStudio.Settings;
 
@@ -83,7 +81,6 @@ public partial class ProviderSelection : MSGComponentBase
         _ => this.T("Uses reasoning (thinking)"),
     };
     
-    [SuppressMessage("Usage", "MWAIS0001:Direct access to `Providers` is not allowed")]
     private IEnumerable<AIStudio.Settings.Provider> GetAvailableProviders()
     {
         switch (this.Component)
@@ -91,25 +88,17 @@ public partial class ProviderSelection : MSGComponentBase
             case null:
                 this.Logger.LogError("Component is null! Cannot filter providers based on component settings. Missed CascadingParameter?");
                 yield break;
-            
+
             case Tools.Components.NONE:
                 this.Logger.LogError("Component is NONE! Cannot filter providers based on component settings. Used wrong component?");
                 yield break;
-            
+
             case { } component:
-                
-                // Get the minimum confidence level for this component, and/or the global minimum if enforced:
-                var minimumLevel = this.SettingsManager.GetMinimumConfidenceLevel(component);
-                
-                // Override with the explicit minimum level if set and higher:
-                if (this.ExplicitMinimumConfidence is not ConfidenceLevel.UNKNOWN && this.ExplicitMinimumConfidence > minimumLevel)
-                    minimumLevel = this.ExplicitMinimumConfidence;
-                
-                // Filter providers based on the minimum confidence level:
-                foreach (var provider in this.SettingsManager.ConfigurationData.Providers)
-                    if (provider.UsedLLMProvider != LLMProviders.NONE)
-                        if (provider.UsedLLMProvider.GetConfidence(this.SettingsManager).Level >= minimumLevel)
-                            yield return provider;
+
+                // Filter providers based on the minimum confidence level of this component, the
+                // enforced global minimum, and the explicit minimum level when it is higher:
+                foreach (var provider in this.SettingsManager.GetConfidentProviders(component, this.ExplicitMinimumConfidence))
+                    yield return provider;
                 break;
         }
     }

app/MindWork AI Studio/Components/Settings/SettingsPanelProviders.razor

@@ -9,7 +9,7 @@
     <MudJustifiedText Typo="Typo.body1" Class="mb-3">
         @T("What we call a provider is the combination of an LLM provider such as OpenAI and a model like GPT-4o. You can configure as many providers as you want. This way, you can use the appropriate model for each task. As an LLM provider, you can also choose local providers. However, to use this app, you must configure at least one provider.")
     </MudJustifiedText>
-    <MudTable Items="@this.SettingsManager.ConfigurationData.Providers" Hover="@true" Class="border-dashed border rounded-lg">
+    <MudTable Items="@this.SettingsManager.GetAllProviders()" Hover="@true" Class="border-dashed border rounded-lg">
         <ColGroup>
             <col style="width: 3em;"/>
             <col style="width: 12em;"/>
@@ -66,7 +66,7 @@
         </RowTemplate>
     </MudTable>
 
-    @if(this.SettingsManager.ConfigurationData.Providers.Count == 0)
+    @if(this.SettingsManager.GetAllProviders().Count == 0)
     {
         <MudText Typo="Typo.h6" Class="mt-3">
             @T("No providers configured yet.")

app/MindWork AI Studio/Components/Settings/SettingsPanelProviders.razor.cs

@@ -27,7 +27,7 @@ public partial class SettingsPanelProviders : SettingsPanelProviderBase
 
     #endregion
     
-    [SuppressMessage("Usage", "MWAIS0001:Direct access to `Providers` is not allowed")]
+    [SuppressMessage("Usage", "MWAIS0001:Direct access to `Providers` is not allowed", Justification = "Managing the provider list is the purpose of this settings panel. Reading providers goes through the settings manager, but adding, editing, and removing them stays here on purpose.")]
     private async Task AddLLMProvider()
     {
         var dialogParameters = new DialogParameters<ProviderDialog>
@@ -50,7 +50,7 @@ public partial class SettingsPanelProviders : SettingsPanelProviderBase
         await this.MessageBus.SendMessage<bool>(this, Event.CONFIGURATION_CHANGED);
     }
 
-    [SuppressMessage("Usage", "MWAIS0001:Direct access to `Providers` is not allowed")]
+    [SuppressMessage("Usage", "MWAIS0001:Direct access to `Providers` is not allowed", Justification = "Managing the provider list is the purpose of this settings panel. Reading providers goes through the settings manager, but adding, editing, and removing them stays here on purpose.")]
     private async Task EditLLMProvider(AIStudio.Settings.Provider provider)
     {
         if(provider == AIStudio.Settings.Provider.NONE)
@@ -94,7 +94,7 @@ public partial class SettingsPanelProviders : SettingsPanelProviderBase
         await this.MessageBus.SendMessage<bool>(this, Event.CONFIGURATION_CHANGED);
     }
 
-    [SuppressMessage("Usage", "MWAIS0001:Direct access to `Providers` is not allowed")]
+    [SuppressMessage("Usage", "MWAIS0001:Direct access to `Providers` is not allowed", Justification = "Managing the provider list is the purpose of this settings panel. Reading providers goes through the settings manager, but adding, editing, and removing them stays here on purpose.")]
     private async Task DeleteLLMProvider(AIStudio.Settings.Provider provider)
     {
         var dialogParameters = new DialogParameters<ConfirmDialog>
@@ -156,11 +156,10 @@ public partial class SettingsPanelProviders : SettingsPanelProviderBase
         return modelName.Length > MAX_LENGTH ? "[...] " + modelName[^Math.Min(MAX_LENGTH, modelName.Length)..] : modelName;
     }
     
-    [SuppressMessage("Usage", "MWAIS0001:Direct access to `Providers` is not allowed")]
     private async Task UpdateProviders()
     {
         this.AvailableLLMProviders.Clear();
-        foreach (var provider in this.SettingsManager.ConfigurationData.Providers)
+        foreach (var provider in this.SettingsManager.GetAllProviders())
             this.AvailableLLMProviders.Add(new (provider.InstanceName, provider.Id));
         
         await this.AvailableLLMProvidersChanged.InvokeAsync(this.AvailableLLMProviders);