Improved error handling for model loading (#732)

app/MindWork AI Studio/Provider/Mistral/ProviderMistral.cs

@@ -1,4 +1,3 @@
-using System.Net.Http.Headers;
 using System.Runtime.CompilerServices;
 
 using AIStudio.Chat;
@@ -77,72 +76,62 @@ public sealed class ProviderMistral() : BaseProvider(LLMProviders.MISTRAL, "http
     }
 
     /// <inheritdoc />
-    public override async Task<IEnumerable<Provider.Model>> GetTextModels(string? apiKeyProvisional = null, CancellationToken token = default)
+    public override async Task<ModelLoadResult> GetTextModels(string? apiKeyProvisional = null, CancellationToken token = default)
     {
         var modelResponse = await this.LoadModelList(SecretStoreType.LLM_PROVIDER, apiKeyProvisional, token);
-        if(modelResponse == default)
-            return [];
+        if(!modelResponse.Success)
+            return modelResponse;
         
-        return modelResponse.Data.Where(n => 
-            !n.Id.StartsWith("code", StringComparison.OrdinalIgnoreCase) &&
-            !n.Id.Contains("embed", StringComparison.OrdinalIgnoreCase) &&
-            !n.Id.Contains("moderation", StringComparison.OrdinalIgnoreCase))
-            .Select(n => new Provider.Model(n.Id, null));
+        return modelResponse with
+        {
+            Models =
+            [
+                ..modelResponse.Models.Where(n =>
+                    !n.Id.StartsWith("code", StringComparison.OrdinalIgnoreCase) &&
+                    !n.Id.Contains("embed", StringComparison.OrdinalIgnoreCase) &&
+                    !n.Id.Contains("moderation", StringComparison.OrdinalIgnoreCase))
+            ]
+        };
     }
     
     /// <inheritdoc />
-    public override async Task<IEnumerable<Provider.Model>> GetEmbeddingModels(string? apiKeyProvisional = null, CancellationToken token = default)
+    public override async Task<ModelLoadResult> GetEmbeddingModels(string? apiKeyProvisional = null, CancellationToken token = default)
     {
         var modelResponse = await this.LoadModelList(SecretStoreType.EMBEDDING_PROVIDER, apiKeyProvisional, token);
-        if(modelResponse == default)
-            return [];
+        if(!modelResponse.Success)
+            return modelResponse;
         
-        return modelResponse.Data.Where(n => n.Id.Contains("embed", StringComparison.InvariantCulture))
-            .Select(n => new Provider.Model(n.Id, null));
+        return modelResponse with
+        {
+            Models = [..modelResponse.Models.Where(n => n.Id.Contains("embed", StringComparison.InvariantCulture))]
+        };
     }
     
     /// <inheritdoc />
-    public override Task<IEnumerable<Provider.Model>> GetImageModels(string? apiKeyProvisional = null, CancellationToken token = default)
+    public override Task<ModelLoadResult> GetImageModels(string? apiKeyProvisional = null, CancellationToken token = default)
     {
-        return Task.FromResult(Enumerable.Empty<Provider.Model>());
+        return Task.FromResult(ModelLoadResult.FromModels([]));
     }
     
     /// <inheritdoc />
-    public override Task<IEnumerable<Provider.Model>> GetTranscriptionModels(string? apiKeyProvisional = null, CancellationToken token = default)
+    public override Task<ModelLoadResult> GetTranscriptionModels(string? apiKeyProvisional = null, CancellationToken token = default)
     {
         // Source: https://docs.mistral.ai/capabilities/audio_transcription
-        return Task.FromResult<IEnumerable<Provider.Model>>(
-            new List<Provider.Model>
-            {
-                new("voxtral-mini-latest", "Voxtral Mini Latest"),
-            });
+        return Task.FromResult(ModelLoadResult.FromModels(
+        [
+            new Provider.Model("voxtral-mini-latest", "Voxtral Mini Latest"),
+        ]));
     }
     
     #endregion
     
-    private async Task<ModelsResponse> LoadModelList(SecretStoreType storeType, string? apiKeyProvisional, CancellationToken token)
+    private Task<ModelLoadResult> LoadModelList(SecretStoreType storeType, string? apiKeyProvisional, CancellationToken token)
     {
-        var secretKey = apiKeyProvisional switch
-        {
-            not null => apiKeyProvisional,
-            _ => await RUST_SERVICE.GetAPIKey(this, storeType) switch
-            {
-                { Success: true } result => await result.Secret.Decrypt(ENCRYPTION),
-                _ => null,
-            }
-        };
-
-        if (secretKey is null)
-            return default;
-        
-        using var request = new HttpRequestMessage(HttpMethod.Get, "models");
-        request.Headers.Authorization = new AuthenticationHeaderValue("Bearer", secretKey);
-
-        using var response = await this.httpClient.SendAsync(request, token);
-        if(!response.IsSuccessStatusCode)
-            return default;
-
-        var modelResponse = await response.Content.ReadFromJsonAsync<ModelsResponse>(token);
-        return modelResponse;
+        return this.LoadModelsResponse<ModelsResponse>(
+            storeType,
+            "models",
+            modelResponse => modelResponse.Data.Select(n => new Provider.Model(n.Id, null)),
+            token,
+            apiKeyProvisional);
     }
-}
+}