mirror of
https://github.com/MindWorkAI/AI-Studio.git
synced 2026-11-21 02:13:49 +00:00
Fixed a misleading tool calling error after a stopped or interrupted answer (#1202)
Co-authored-by: Thorsten Sommer <SommerEngineering@users.noreply.github.com>
This commit is contained in:
1 parent
fb8f51dec4
commit
ca7413d84c
18 files changed
+272
-76
No files matched your search
@@ -245,6 +245,52 @@ public sealed class ToolCallingLoopTests
|
||||
}
|
||||
}
|
||||
|
||||
[Test]
|
||||
public async Task AStopRightAfterASilentRoundIsNotReportedAsAnInvalidAnswer()
|
||||
{
|
||||
//
|
||||
// The user stops the answer just after the provider closed the stream of a round which
|
||||
// said nothing and called nothing, e.g., of a reasoning model which never got to its first
|
||||
// word. That is no invalid answer of the provider, and reporting it as one would put an
|
||||
// error message on top of the stop.
|
||||
//
|
||||
using var cancellation = new CancellationTokenSource();
|
||||
var adapter = new ScriptedAdapter([Completed(string.Empty)])
|
||||
{
|
||||
CancelAfterFirstEvent = cancellation,
|
||||
};
|
||||
|
||||
var chunks = await Collect(adapter, cancellation.Token);
|
||||
|
||||
Assert.That(string.Concat(chunks.Select(x => x.Content)), Is.Empty, "A stop is neither an error nor an answer, so nothing is written on its behalf.");
|
||||
}
|
||||
|
||||
[Test]
|
||||
public async Task AToolCallWhichArrivedBeforeTheStopDoesNotRun()
|
||||
{
|
||||
//
|
||||
// The model asked for a tool, and the user stopped the answer before the tool ran. Running
|
||||
// it anyway would act on behalf of an answer nobody waits for any longer, e.g., search the
|
||||
// web with the question of the chat, and then ask the model for a round of its own.
|
||||
//
|
||||
using var cancellation = new CancellationTokenSource();
|
||||
var adapter = new ScriptedAdapter(
|
||||
[Completed(string.Empty, [Call("call-1")])],
|
||||
[Text(ANSWER), Completed(ANSWER)])
|
||||
{
|
||||
CancelAfterFirstEvent = cancellation,
|
||||
};
|
||||
|
||||
var written = string.Concat((await Collect(adapter, cancellation.Token)).Select(x => x.Content));
|
||||
|
||||
using (Assert.EnterMultipleScope())
|
||||
{
|
||||
Assert.That(adapter.Recordings, Is.Empty, "Nothing is recorded and nothing is run once the user said stop.");
|
||||
Assert.That(adapter.RequestedRounds, Is.EqualTo(1), "No further round is asked for.");
|
||||
Assert.That(written, Is.Empty, "And nothing is written on behalf of the stop.");
|
||||
}
|
||||
}
|
||||
|
||||
[Test]
|
||||
public async Task OnlyTheFirstRoundsUsageReachesTheAnswer()
|
||||
{
|
||||
@@ -362,13 +408,19 @@ public sealed class ToolCallingLoopTests
|
||||
/// What the loop recorded, in the order it did.
|
||||
/// </summary>
|
||||
public List<string> Recordings { get; } = [];
|
||||
|
||||
|
||||
/// <summary>
|
||||
/// How many rounds the loop asked for.
|
||||
/// </summary>
|
||||
public int RequestedRounds { get; private set; }
|
||||
|
||||
/// <inheritdoc />
|
||||
public IReadOnlyList<string> RecordedRequestTexts => [];
|
||||
|
||||
|
||||
/// <inheritdoc />
|
||||
public async IAsyncEnumerable<ToolCallingStreamEvent> ExecuteRoundAsync(string? finalResponseInstruction, bool includeTools, [EnumeratorCancellation] CancellationToken token = default)
|
||||
{
|
||||
this.RequestedRounds++;
|
||||
await Task.Yield();
|
||||
if (this.remainingRounds.Count is 0)
|
||||
yield break;
|
||||
|
||||
Reference in new issue
Block a user