From c6ed7e3c0cee8824b04eb307ad0be16bcfd6fcd9 Mon Sep 17 00:00:00 2001 From: Thorsten Sommer Date: Fri, 17 Apr 2026 19:22:55 +0200 Subject: [PATCH] Improved update service with error handling and logging --- .../Assistants/I18N/allTexts.lua | 3 +++ .../plugin.lua | 3 +++ .../plugin.lua | 3 +++ .../Tools/Services/RustService.Updates.cs | 18 ++++++++++++++++ .../Tools/Services/UpdateService.cs | 21 ++++++++++++++++++- 5 files changed, 47 insertions(+), 1 deletion(-) diff --git a/app/MindWork AI Studio/Assistants/I18N/allTexts.lua b/app/MindWork AI Studio/Assistants/I18N/allTexts.lua index 73a9c8ee..07569e09 100644 --- a/app/MindWork AI Studio/Assistants/I18N/allTexts.lua +++ b/app/MindWork AI Studio/Assistants/I18N/allTexts.lua @@ -7513,6 +7513,9 @@ UI_TEXT_CONTENT["AISTUDIO::TOOLS::SERVICES::RUSTSERVICE::T4007657575"] = "Failed -- No update found. UI_TEXT_CONTENT["AISTUDIO::TOOLS::SERVICES::UPDATESERVICE::T1015418291"] = "No update found." +-- Failed to check for updates. Please try again later. +UI_TEXT_CONTENT["AISTUDIO::TOOLS::SERVICES::UPDATESERVICE::T1064148123"] = "Failed to check for updates. Please try again later." + -- Failed to install update automatically. Please try again manually. UI_TEXT_CONTENT["AISTUDIO::TOOLS::SERVICES::UPDATESERVICE::T3709709946"] = "Failed to install update automatically. Please try again manually." diff --git a/app/MindWork AI Studio/Plugins/languages/de-de-43065dbc-78d0-45b7-92be-f14c2926e2dc/plugin.lua b/app/MindWork AI Studio/Plugins/languages/de-de-43065dbc-78d0-45b7-92be-f14c2926e2dc/plugin.lua index b844c0e4..b65b6552 100644 --- a/app/MindWork AI Studio/Plugins/languages/de-de-43065dbc-78d0-45b7-92be-f14c2926e2dc/plugin.lua +++ b/app/MindWork AI Studio/Plugins/languages/de-de-43065dbc-78d0-45b7-92be-f14c2926e2dc/plugin.lua @@ -7515,6 +7515,9 @@ UI_TEXT_CONTENT["AISTUDIO::TOOLS::SERVICES::RUSTSERVICE::T4007657575"] = "Abrufe -- No update found. UI_TEXT_CONTENT["AISTUDIO::TOOLS::SERVICES::UPDATESERVICE::T1015418291"] = "Kein Update gefunden." +-- Failed to check for updates. Please try again later. +UI_TEXT_CONTENT["AISTUDIO::TOOLS::SERVICES::UPDATESERVICE::T1064148123"] = "Die Suche nach Updates ist fehlgeschlagen. Bitte versuchen Sie es später erneut." + -- Failed to install update automatically. Please try again manually. UI_TEXT_CONTENT["AISTUDIO::TOOLS::SERVICES::UPDATESERVICE::T3709709946"] = "Fehler bei der automatischen Installation des Updates. Bitte versuchen Sie es manuell erneut." diff --git a/app/MindWork AI Studio/Plugins/languages/en-us-97dfb1ba-50c4-4440-8dfa-6575daf543c8/plugin.lua b/app/MindWork AI Studio/Plugins/languages/en-us-97dfb1ba-50c4-4440-8dfa-6575daf543c8/plugin.lua index a64b11df..434c6aa3 100644 --- a/app/MindWork AI Studio/Plugins/languages/en-us-97dfb1ba-50c4-4440-8dfa-6575daf543c8/plugin.lua +++ b/app/MindWork AI Studio/Plugins/languages/en-us-97dfb1ba-50c4-4440-8dfa-6575daf543c8/plugin.lua @@ -7515,6 +7515,9 @@ UI_TEXT_CONTENT["AISTUDIO::TOOLS::SERVICES::RUSTSERVICE::T4007657575"] = "Failed -- No update found. UI_TEXT_CONTENT["AISTUDIO::TOOLS::SERVICES::UPDATESERVICE::T1015418291"] = "No update found." +-- Failed to check for updates. Please try again later. +UI_TEXT_CONTENT["AISTUDIO::TOOLS::SERVICES::UPDATESERVICE::T1064148123"] = "Failed to check for updates. Please try again later." + -- Failed to install update automatically. Please try again manually. UI_TEXT_CONTENT["AISTUDIO::TOOLS::SERVICES::UPDATESERVICE::T3709709946"] = "Failed to install update automatically. Please try again manually." diff --git a/app/MindWork AI Studio/Tools/Services/RustService.Updates.cs b/app/MindWork AI Studio/Tools/Services/RustService.Updates.cs index 1686b777..fdf2a211 100644 --- a/app/MindWork AI Studio/Tools/Services/RustService.Updates.cs +++ b/app/MindWork AI Studio/Tools/Services/RustService.Updates.cs @@ -10,6 +10,22 @@ public sealed partial class RustService { var cts = new CancellationTokenSource(TimeSpan.FromSeconds(45)); var response = await this.http.GetFromJsonAsync("/updates/check", this.jsonRustSerializerOptions, cts.Token); + + if (response == default) + { + this.logger!.LogError("Failed to check for an update: the Rust endpoint returned an empty response."); + return new UpdateResponse + { + Error = true, + UpdateIsAvailable = false, + NewVersion = string.Empty, + Changelog = string.Empty + }; + } + + if (response.Error) + this.logger!.LogWarning("The Rust updater reported an error while checking for updates."); + this.logger!.LogInformation($"Checked for an update: update available='{response.UpdateIsAvailable}'; error='{response.Error}'; next version='{response.NewVersion}'; changelog len='{response.Changelog.Length}'"); return response; } @@ -20,6 +36,8 @@ public sealed partial class RustService { Error = true, UpdateIsAvailable = false, + NewVersion = string.Empty, + Changelog = string.Empty }; } } diff --git a/app/MindWork AI Studio/Tools/Services/UpdateService.cs b/app/MindWork AI Studio/Tools/Services/UpdateService.cs index 8c0e8565..4a873242 100644 --- a/app/MindWork AI Studio/Tools/Services/UpdateService.cs +++ b/app/MindWork AI Studio/Tools/Services/UpdateService.cs @@ -16,14 +16,16 @@ public sealed class UpdateService : BackgroundService, IMessageBusReceiver private readonly SettingsManager settingsManager; private readonly MessageBus messageBus; private readonly RustService rust; + private readonly ILogger logger; private TimeSpan updateInterval; - public UpdateService(MessageBus messageBus, SettingsManager settingsManager, RustService rust) + public UpdateService(MessageBus messageBus, SettingsManager settingsManager, RustService rust, ILogger logger) { this.settingsManager = settingsManager; this.messageBus = messageBus; this.rust = rust; + this.logger = logger; this.messageBus.RegisterComponent(this); this.ApplyFilters([], [ Event.USER_SEARCH_FOR_UPDATE ]); @@ -113,6 +115,23 @@ public sealed class UpdateService : BackgroundService, IMessageBusReceiver return; var response = await this.rust.CheckForUpdate(); + if (response.Error) + { + this.logger.LogWarning("Update check failed. The updater did not return a usable result."); + + if (notifyUserWhenNoUpdate) + { + SNACKBAR!.Add(TB("Failed to check for updates. Please try again later."), Severity.Error, config => + { + config.Icon = Icons.Material.Filled.Error; + config.IconSize = Size.Large; + config.IconColor = Color.Error; + }); + } + + return; + } + if (response.UpdateIsAvailable) { // ReSharper disable RedundantAssignment