MindWorkAI/AI-Studio
MindWorkAI/AI-Studio
1
0
Fork 0
mirror of https://github.com/MindWorkAI/AI-Studio.git synced 2026-08-24 20:52:11 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fixed deletion of the existing assistant plugin when its backup failed

Browse Source
This commit is contained in:
Thorsten Sommer 2026-08-05 16:22:59 +02:00
parent e0057b67ae
commit c50ca0dd54
Signed by untrusted user who does not match committer: tsommer
GPG Key ID: 371BBA77A02C0108
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
app/MindWork AI Studio/Tools/Services/AssistantPluginInstallService.cs
View File

@ -427,6 +427,7 @@ public sealed class AssistantPluginInstallService
string? backupDirectory = null; string? backupDirectory = null;
string? finalDirectory = null; string? finalDirectory = null;
var replacedExisting = false; var replacedExisting = false;
var movedIntoPlace = false;
try try
{ {
@ -443,6 +444,7 @@ public sealed class AssistantPluginInstallService
} }
Directory.Move(stagingDirectory, finalDirectory); Directory.Move(stagingDirectory, finalDirectory);
movedIntoPlace = true;
await PluginFactory.LoadAll(token); await PluginFactory.LoadAll(token);
if (!string.IsNullOrWhiteSpace(backupDirectory)) if (!string.IsNullOrWhiteSpace(backupDirectory))
@ -455,7 +457,10 @@ public sealed class AssistantPluginInstallService
{ {
this.logger.LogError(e, "Failed to install assistant plugin."); this.logger.LogError(e, "Failed to install assistant plugin.");
if (!string.IsNullOrWhiteSpace(finalDirectory) && Directory.Exists(finalDirectory)) // Only remove the target directory when this installation actually moved the plugin
// there. Otherwise, when moving the previous plugin into the backup directory failed,
// we would delete the still intact previous plugin:
if (movedIntoPlace && !string.IsNullOrWhiteSpace(finalDirectory) && Directory.Exists(finalDirectory))
TryDeleteDirectory(finalDirectory, "failed assistant plugin installation", this.logger); TryDeleteDirectory(finalDirectory, "failed assistant plugin installation", this.logger);
if (!string.IsNullOrWhiteSpace(backupDirectory) && Directory.Exists(backupDirectory) && !string.IsNullOrWhiteSpace(finalDirectory) && !Directory.Exists(finalDirectory)) if (!string.IsNullOrWhiteSpace(backupDirectory) && Directory.Exists(backupDirectory) && !string.IsNullOrWhiteSpace(finalDirectory) && !Directory.Exists(finalDirectory))