Refactored configuration objects (#538)

app/MindWork AI Studio/Settings/ChatTemplate.cs

@@ -1,9 +1,20 @@
 using AIStudio.Chat;
 using AIStudio.Tools.PluginSystem;
 
+using Lua;
+
 namespace AIStudio.Settings;
 
-public record ChatTemplate(uint Num, string Id, string Name, string SystemPrompt, string PredefinedUserPrompt, List<ContentBlock> ExampleConversation, bool AllowProfileUsage, bool IsEnterpriseConfiguration = false, Guid EnterpriseConfigurationPluginId = default)
+public record ChatTemplate(
+    uint Num,
+    string Id,
+    string Name,
+    string SystemPrompt,
+    string PredefinedUserPrompt,
+    List<ContentBlock> ExampleConversation,
+    bool AllowProfileUsage,
+    bool IsEnterpriseConfiguration = false,
+    Guid EnterpriseConfigurationPluginId = default) : ConfigurationBaseObject
 {
     public ChatTemplate() : this(0, Guid.Empty.ToString(), string.Empty, string.Empty, string.Empty, [], false)
     {
@@ -11,6 +22,8 @@ public record ChatTemplate(uint Num, string Id, string Name, string SystemPrompt
     
     private static string TB(string fallbackEN) => I18N.I.T(fallbackEN, typeof(ChatTemplate).Namespace, nameof(ChatTemplate));
     
+    private static readonly ILogger<ChatTemplate> LOGGER = Program.LOGGER_FACTORY.CreateLogger<ChatTemplate>();
+    
     public static readonly ChatTemplate NO_CHAT_TEMPLATE = new()
     {
         Name = TB("Use no chat template"),
@@ -41,4 +54,96 @@ public record ChatTemplate(uint Num, string Id, string Name, string SystemPrompt
         
         return this.SystemPrompt;
     }
+    
+    public static bool TryParseChatTemplateTable(int idx, LuaTable table, Guid configPluginId, out ConfigurationBaseObject template)
+    {
+        template = NO_CHAT_TEMPLATE;
+        if (!table.TryGetValue("Id", out var idValue) || !idValue.TryRead<string>(out var idText) || !Guid.TryParse(idText, out var id))
+        {
+            LOGGER.LogWarning($"The configured chat template {idx} does not contain a valid ID. The ID must be a valid GUID.");
+            return false;
+        }
+        
+        if (!table.TryGetValue("Name", out var nameValue) || !nameValue.TryRead<string>(out var name))
+        {
+            LOGGER.LogWarning($"The configured chat template {idx} does not contain a valid name.");
+            return false;
+        }
+        
+        if (!table.TryGetValue("SystemPrompt", out var sysPromptValue) || !sysPromptValue.TryRead<string>(out var systemPrompt))
+        {
+            LOGGER.LogWarning($"The configured chat template {idx} does not contain a valid system prompt.");
+            return false;
+        }
+        
+        var predefinedUserPrompt = string.Empty;
+        if (table.TryGetValue("PredefinedUserPrompt", out var preUserValue) && preUserValue.TryRead<string>(out var preUser))
+            predefinedUserPrompt = preUser;
+        
+        var allowProfileUsage = false;
+        if (table.TryGetValue("AllowProfileUsage", out var allowProfileValue) && allowProfileValue.TryRead<bool>(out var allow))
+            allowProfileUsage = allow;
+        
+        template = new ChatTemplate
+        {
+            Num = 0,
+            Id = id.ToString(),
+            Name = name,
+            SystemPrompt = systemPrompt,
+            PredefinedUserPrompt = predefinedUserPrompt,
+            ExampleConversation = ParseExampleConversation(idx, table),
+            AllowProfileUsage = allowProfileUsage,
+            IsEnterpriseConfiguration = true,
+            EnterpriseConfigurationPluginId = configPluginId,
+        };
+        
+        return true;
+    }
+    
+    private static List<ContentBlock> ParseExampleConversation(int idx, LuaTable table)
+    {
+        var exampleConversation = new List<ContentBlock>();
+        if (!table.TryGetValue("ExampleConversation", out var exConvValue) || !exConvValue.TryRead<LuaTable>(out var exConvTable))
+            return exampleConversation;
+        
+        var numBlocks = exConvTable.ArrayLength;
+        for (var j = 1; j <= numBlocks; j++)
+        {
+            var blockValue = exConvTable[j];
+            if (!blockValue.TryRead<LuaTable>(out var blockTable))
+            {
+                LOGGER.LogWarning($"The ExampleConversation entry {j} in chat template {idx} is not a valid table.");
+                continue;
+            }
+            
+            if (!blockTable.TryGetValue("Role", out var roleValue) || !roleValue.TryRead<string>(out var roleText) || !Enum.TryParse<ChatRole>(roleText, true, out var parsedRole))
+            {
+                LOGGER.LogWarning($"The ExampleConversation entry {j} in chat template {idx} does not contain a valid role.");
+                continue;
+            }
+
+            if (!blockTable.TryGetValue("Content", out var contentValue) || !contentValue.TryRead<string>(out var content))
+            {
+                LOGGER.LogWarning($"The ExampleConversation entry {j} in chat template {idx} does not contain a valid content message.");
+                continue;
+            }
+                
+            if (string.IsNullOrWhiteSpace(content))
+            {
+                LOGGER.LogWarning($"The ExampleConversation entry {j} in chat template {idx} contains an empty content message.");
+                continue;
+            }
+                
+            exampleConversation.Add(new ContentBlock
+            {
+                Time = DateTimeOffset.UtcNow,
+                Role = parsedRole,
+                Content = new ContentText { Text = content },
+                ContentType = ContentType.TEXT,
+                HideFromUser = true,
+            });
+        }
+
+        return exampleConversation;
+    }
 }

app/MindWork AI Studio/Settings/ExpressionExtensions.cs

@@ -1,26 +0,0 @@
-using System.Linq.Expressions;
-
-namespace AIStudio.Settings;
-
-public static class ExpressionExtensions
-{
-    private static readonly ILogger LOGGER = Program.LOGGER_FACTORY.CreateLogger(typeof(ExpressionExtensions));
-
-    public static MemberExpression GetMemberExpression<TIn, TOut>(this Expression<Func<TIn, TOut>> expression)
-    {
-        switch (expression.Body)
-        {
-            // Case for value types, which are wrapped in UnaryExpression:
-            case UnaryExpression { NodeType: ExpressionType.Convert } unaryExpression:
-                return (MemberExpression)unaryExpression.Operand;
-
-            // Case for reference types, which are directly MemberExpressions:
-            case MemberExpression memberExpression:
-                return memberExpression;
-            
-            default:
-                LOGGER.LogError($"Expression '{expression}' is not a valid property expression.");
-                throw new ArgumentException($"Expression '{expression}' is not a valid property expression.", nameof(expression));
-        }
-    }
-}

app/MindWork AI Studio/Settings/Provider.cs

@@ -2,6 +2,10 @@ using System.Text.Json.Serialization;
 
 using AIStudio.Provider;
 using AIStudio.Provider.HuggingFace;
+using AIStudio.Tools.PluginSystem;
+
+using Lua;
+
 using Host = AIStudio.Provider.SelfHosted.Host;
 
 namespace AIStudio.Settings;
@@ -16,7 +20,7 @@ namespace AIStudio.Settings;
 /// <param name="IsSelfHosted">Whether the provider is self-hosted.</param>
 /// <param name="Hostname">The hostname of the provider. Useful for self-hosted providers.</param>
 /// <param name="Model">The LLM model to use for chat.</param>
-public readonly record struct Provider(
+public sealed record Provider(
     uint Num,
     string Id,
     string InstanceName,
@@ -27,8 +31,24 @@ public readonly record struct Provider(
     Guid EnterpriseConfigurationPluginId = default,
     string Hostname = "http://localhost:1234",
     Host Host = Host.NONE,
-    HFInferenceProvider HFInferenceProvider = HFInferenceProvider.NONE) : ISecretId
+    HFInferenceProvider HFInferenceProvider = HFInferenceProvider.NONE) : ConfigurationBaseObject, ISecretId
 {
+    private static readonly ILogger<Provider> LOGGER = Program.LOGGER_FACTORY.CreateLogger<Provider>();
+    
+    public static readonly Provider NONE = new();
+
+    public Provider() : this(
+        0,
+        Guid.Empty.ToString(),
+        string.Empty,
+        LLMProviders.NONE,
+        default, 
+        false,
+        false,
+        Guid.Empty)
+    {
+    }
+    
     #region Overrides of ValueType
 
     /// <summary>
@@ -57,4 +77,95 @@ public readonly record struct Provider(
     public string SecretName => this.InstanceName;
     
     #endregion
+
+    #region Implementation of IConfigurationObject
+
+    public override string Name
+    {
+        get => this.InstanceName;
+        init => this.InstanceName = value;
+    }
+
+    #endregion
+    
+    public static bool TryParseProviderTable(int idx, LuaTable table, Guid configPluginId, out ConfigurationBaseObject provider)
+    {
+        provider = NONE;
+        if (!table.TryGetValue("Id", out var idValue) || !idValue.TryRead<string>(out var idText) || !Guid.TryParse(idText, out var id))
+        {
+            LOGGER.LogWarning($"The configured provider {idx} does not contain a valid ID. The ID must be a valid GUID.");
+            return false;
+        }
+
+        if (!table.TryGetValue("InstanceName", out var instanceNameValue) || !instanceNameValue.TryRead<string>(out var instanceName))
+        {
+            LOGGER.LogWarning($"The configured provider {idx} does not contain a valid instance name.");
+            return false;
+        }
+
+        if (!table.TryGetValue("UsedLLMProvider", out var usedLLMProviderValue) || !usedLLMProviderValue.TryRead<string>(out var usedLLMProviderText) || !Enum.TryParse<LLMProviders>(usedLLMProviderText, true, out var usedLLMProvider))
+        {
+            LOGGER.LogWarning($"The configured provider {idx} does not contain a valid LLM provider enum value.");
+            return false;
+        }
+        
+        if (!table.TryGetValue("Host", out var hostValue) || !hostValue.TryRead<string>(out var hostText) || !Enum.TryParse<Host>(hostText, true, out var host))
+        {
+            LOGGER.LogWarning($"The configured provider {idx} does not contain a valid host enum value.");
+            return false;
+        }
+        
+        if (!table.TryGetValue("Hostname", out var hostnameValue) || !hostnameValue.TryRead<string>(out var hostname))
+        {
+            LOGGER.LogWarning($"The configured provider {idx} does not contain a valid hostname.");
+            return false;
+        }
+        
+        if (!table.TryGetValue("Model", out var modelValue) || !modelValue.TryRead<LuaTable>(out var modelTable))
+        {
+            LOGGER.LogWarning($"The configured provider {idx} does not contain a valid model table.");
+            return false;
+        }
+        
+        if (!TryReadModelTable(idx, modelTable, out var model))
+        {
+            LOGGER.LogWarning($"The configured provider {idx} does not contain a valid model configuration.");
+            return false;
+        }
+
+        provider = new Provider
+        {
+            Num = 0,
+            Id = id.ToString(),
+            InstanceName = instanceName,
+            UsedLLMProvider = usedLLMProvider,
+            Model = model,
+            IsSelfHosted = usedLLMProvider is LLMProviders.SELF_HOSTED,
+            IsEnterpriseConfiguration = true,
+            EnterpriseConfigurationPluginId = configPluginId,
+            Hostname = hostname,
+            Host = host
+        };
+        
+        return true;
+    }
+
+    private static bool TryReadModelTable(int idx, LuaTable table, out Model model)
+    {
+        model = default;
+        if (!table.TryGetValue("Id", out var idValue) || !idValue.TryRead<string>(out var id))
+        {
+            LOGGER.LogWarning($"The configured provider {idx} does not contain a valid model ID.");
+            return false;
+        }
+        
+        if (!table.TryGetValue("DisplayName", out var displayNameValue) || !displayNameValue.TryRead<string>(out var displayName))
+        {
+            LOGGER.LogWarning($"The configured provider {idx} does not contain a valid model display name.");
+            return false;
+        }
+        
+        model = new(id, displayName);
+        return true;
+    }
 }

app/MindWork AI Studio/Settings/SettingsManager.cs

@@ -215,18 +215,18 @@ public sealed class SettingsManager
             return this.ConfigurationData.Providers[0];
 
         // Is there a current provider with a sufficiently high confidence level?
-        Provider currentProvider = default;
+        var currentProvider = Provider.NONE;
         if (currentProviderId is not null && !string.IsNullOrWhiteSpace(currentProviderId))
         {
             var currentProviderProbe = this.ConfigurationData.Providers.FirstOrDefault(x => x.Id == currentProviderId);
-            if (currentProviderProbe.UsedLLMProvider.GetConfidence(this).Level >= minimumLevel)
+            if (currentProviderProbe is not null && currentProviderProbe.UsedLLMProvider.GetConfidence(this).Level >= minimumLevel)
                 currentProvider = currentProviderProbe;
         }
         
         // Is there a component-preselected provider with a sufficiently high confidence level?
-        Provider preselectedProvider = default;
+        var preselectedProvider = Provider.NONE;
         var preselectedProviderProbe = component.PreselectedProvider(this);
-        if(preselectedProviderProbe != default && preselectedProviderProbe.UsedLLMProvider.GetConfidence(this).Level >= minimumLevel)
+        if(preselectedProviderProbe != Provider.NONE && preselectedProviderProbe.UsedLLMProvider.GetConfidence(this).Level >= minimumLevel)
             preselectedProvider = preselectedProviderProbe;
 
         //
@@ -234,14 +234,14 @@ public sealed class SettingsManager
         //       and the preselected provider is available and has a confidence level
         //       that is high enough.
         //
-        if(usePreselectionBeforeCurrentProvider && preselectedProvider != default)
+        if(usePreselectionBeforeCurrentProvider && preselectedProvider != Provider.NONE)
             return preselectedProvider;
         
         //
         // Case: The current provider is available and has a confidence level that is
         //       high enough.
         //
-        if(currentProvider != default)
+        if(currentProvider != Provider.NONE)
             return currentProvider;
         
         //
@@ -250,11 +250,11 @@ public sealed class SettingsManager
         //       level that is high enough. The preselected provider is available and
         //       has a confidence level that is high enough.
         //
-        if(preselectedProvider != default)
+        if(preselectedProvider != Provider.NONE)
             return preselectedProvider;
 
         // When there is an app-wide preselected provider, and it has a confidence level that is high enough, we return it:
-        return this.ConfigurationData.Providers.FirstOrDefault(x => x.Id == this.ConfigurationData.App.PreselectedProvider && x.UsedLLMProvider.GetConfidence(this).Level >= minimumLevel);
+        return this.ConfigurationData.Providers.FirstOrDefault(x => x.Id == this.ConfigurationData.App.PreselectedProvider && x.UsedLLMProvider.GetConfidence(this).Level >= minimumLevel) ?? Provider.NONE;
     }
 
     public Profile GetPreselectedProfile(Tools.Components component)