Enhanced enterprise config support (#666)

app/MindWork AI Studio/Tools/PluginSystem/PluginFactory.Download.cs

@@ -5,10 +5,10 @@ namespace AIStudio.Tools.PluginSystem;
 
 public static partial class PluginFactory
 {
-    public static async Task<EntityTagHeaderValue?> DetermineConfigPluginETagAsync(Guid configPlugId, string configServerUrl, CancellationToken cancellationToken = default)
+    public static async Task<(bool Success, EntityTagHeaderValue? ETag, string? Issue)> DetermineConfigPluginETagAsync(Guid configPlugId, string configServerUrl, CancellationToken cancellationToken = default)
     {
         if(configPlugId == Guid.Empty || string.IsNullOrWhiteSpace(configServerUrl))
-            return null;
+            return (false, null, "Configuration ID or server URL is missing.");
         
         try
         {
@@ -18,18 +18,24 @@ public static partial class PluginFactory
             using var http = new HttpClient();
             using var request = new HttpRequestMessage(HttpMethod.Get, downloadUrl);
             var response = await http.SendAsync(request, HttpCompletionOption.ResponseHeadersRead, cancellationToken);
-            return response.Headers.ETag;
+            if (!response.IsSuccessStatusCode)
+            {
+                LOG.LogError($"Failed to determine the ETag for configuration plugin '{configPlugId}'. HTTP Status: {response.StatusCode}");
+                return (false, null, $"HTTP status: {response.StatusCode}");
+            }
+
+            return (true, response.Headers.ETag, null);
         }
         catch (Exception e)
         {
             LOG.LogError(e, "An error occurred while determining the ETag for the configuration plugin.");
-            return null;
+            return (false, null, e.Message);
         }
     }
     
     public static async Task<bool> TryDownloadingConfigPluginAsync(Guid configPlugId, string configServerUrl, CancellationToken cancellationToken = default)
     {
-        if(!IS_INITIALIZED)
+        if(!IsInitialized)
         {
             LOG.LogWarning("Plugin factory is not yet initialized. Cannot download configuration plugin.");
             return false;
@@ -40,36 +46,72 @@ public static partial class PluginFactory
         
         LOG.LogInformation($"Try to download configuration plugin with ID='{configPlugId}' from server='{configServerUrl}' (GET {downloadUrl})");
         var tempDownloadFile = Path.GetTempFileName();
+        var stagedDirectory = Path.Join(CONFIGURATION_PLUGINS_ROOT, $"{configPlugId}.staging-{Guid.NewGuid():N}");
+        string? backupDirectory = null;
+        var wasSuccessful = false;
         try
         {
             await LockHotReloadAsync();
             using var httpClient = new HttpClient();
             var response = await httpClient.GetAsync(downloadUrl, cancellationToken);
-            if (response.IsSuccessStatusCode)
+            if (!response.IsSuccessStatusCode)
             {
-                await using(var tempFileStream = File.Create(tempDownloadFile))
-                {
-                    await response.Content.CopyToAsync(tempFileStream, cancellationToken);
-                }
-                
-                var configDirectory = Path.Join(CONFIGURATION_PLUGINS_ROOT, configPlugId.ToString());
-                if(Directory.Exists(configDirectory))
-                    Directory.Delete(configDirectory, true);
-                
-                Directory.CreateDirectory(configDirectory);
-                ZipFile.ExtractToDirectory(tempDownloadFile, configDirectory);
-                
-                LOG.LogInformation($"Configuration plugin with ID='{configPlugId}' downloaded and extracted successfully to '{configDirectory}'.");
-            }
-            else
                 LOG.LogError($"Failed to download the enterprise configuration plugin. HTTP Status: {response.StatusCode}");
+                return false;
+            }
+
+            await using(var tempFileStream = File.Create(tempDownloadFile))
+            {
+                await response.Content.CopyToAsync(tempFileStream, cancellationToken);
+            }
+
+            ZipFile.ExtractToDirectory(tempDownloadFile, stagedDirectory);
+
+            var configDirectory = Path.Join(CONFIGURATION_PLUGINS_ROOT, configPlugId.ToString());
+            if (Directory.Exists(configDirectory))
+            {
+                backupDirectory = Path.Join(CONFIGURATION_PLUGINS_ROOT, $"{configPlugId}.backup-{Guid.NewGuid():N}");
+                Directory.Move(configDirectory, backupDirectory);
+            }
+
+            Directory.Move(stagedDirectory, configDirectory);
+            if (!string.IsNullOrWhiteSpace(backupDirectory) && Directory.Exists(backupDirectory))
+                Directory.Delete(backupDirectory, true);
+
+            LOG.LogInformation($"Configuration plugin with ID='{configPlugId}' downloaded and extracted successfully to '{configDirectory}'.");
+            wasSuccessful = true;
         }
         catch (Exception e)
         {
             LOG.LogError(e, "An error occurred while downloading or extracting the enterprise configuration plugin.");
+
+            var configDirectory = Path.Join(CONFIGURATION_PLUGINS_ROOT, configPlugId.ToString());
+            if (!string.IsNullOrWhiteSpace(backupDirectory) && Directory.Exists(backupDirectory) && !Directory.Exists(configDirectory))
+            {
+                try
+                {
+                    Directory.Move(backupDirectory, configDirectory);
+                }
+                catch (Exception restoreException)
+                {
+                    LOG.LogError(restoreException, "Failed to restore the previous configuration plugin after a failed update.");
+                }
+            }
         }
         finally
         {
+            if (Directory.Exists(stagedDirectory))
+            {
+                try
+                {
+                    Directory.Delete(stagedDirectory, true);
+                }
+                catch (Exception e)
+                {
+                    LOG.LogError(e, "Failed to delete the staged configuration plugin directory.");
+                }
+            }
+
             if (File.Exists(tempDownloadFile))
             {
                 try
@@ -85,6 +127,6 @@ public static partial class PluginFactory
             UnlockHotReload();
         }
         
-        return true;
+        return wasSuccessful;
     }
 }