Code Review and bug fixes

This commit is contained in:
Peer Hogeterp committed 2026-09-10 14:29:35 +02:00
1 parent cefc5464d5
commit a6e9066747
18 files changed
+443 -186

No files matched your search

@@ -433,8 +433,20 @@ public sealed class PluginConfiguration(bool isInternal, LuaState state, PluginT
}
var legacyOverrideName = $"{singularName}.AllowUserOverride";
var pluralOverrideName = $"{pluralName}.AllowUserOverride";
if (settings.TryGetValue(legacyOverrideName, out var legacyOverride))
settings[$"{pluralName}.AllowUserOverride"] = legacyOverride;
{
if (settings.TryGetValue(pluralOverrideName, out var pluralOverride))
{
if (!Equals(legacyOverride, pluralOverride))
{
message = string.Format(TB("The SETTINGS table contains both '{0}' and '{1}'. Use only one of them."), legacyOverrideName, pluralOverrideName);
return false;
}
}
else
settings[pluralOverrideName] = legacyOverride;
}
}
message = string.Empty;
@@ -789,7 +789,8 @@ public sealed class AssistantPluginGenerationService(ToolRegistry toolRegistry,
var requestedProfileIds = requested.ProfileIds?.Select(Guid.Parse).ToArray();
if (!(requestedProfileIds is null && actual.ProfileIds is null ||
requestedProfileIds is not null && actual.ProfileIds is not null && requestedProfileIds.SequenceEqual(actual.ProfileIds)))
requestedProfileIds is not null && actual.ProfileIds is not null &&
requestedProfileIds.ToHashSet().SetEquals(actual.ProfileIds)))
return false;
var requestedDataSourceIds = requested.DataSourceIds?.Select(Guid.Parse).ToArray();