Improved error handling in Microsoft Word export (#586)

app/MindWork AI Studio/Tools/Pandoc.cs

@@ -49,19 +49,26 @@ public static partial class Pandoc
             {
                 if (showMessages)
                     await MessageBus.INSTANCE.SendError(new (Icons.Material.Filled.Help, TB("Was not able to check the Pandoc installation.")));
-                
+
                 LOG.LogInformation("The Pandoc process was not started, it was null");
                 return new(false, TB("Was not able to check the Pandoc installation."), false, string.Empty, preparedProcess.IsLocal);
             }
-                
-            var output = await process.StandardOutput.ReadToEndAsync();
+
+            // Read output streams asynchronously while the process runs (prevents deadlock):
+            var outputTask = process.StandardOutput.ReadToEndAsync();
+            var errorTask = process.StandardError.ReadToEndAsync();
+
+            // Wait for the process to exit AND for streams to be fully read:
             await process.WaitForExitAsync();
+            var output = await outputTask;
+            var error = await errorTask;
+
             if (process.ExitCode != 0)
             {
                 if (showMessages)
                     await MessageBus.INSTANCE.SendError(new (Icons.Material.Filled.Error, TB("Pandoc is not available on the system or the process had issues.")));
-                
-                LOG.LogError("The Pandoc process was exited with code {ProcessExitCode}", process.ExitCode);
+
+                LOG.LogError("The Pandoc process exited with code {ProcessExitCode}. Error output: '{ErrorText}'", process.ExitCode, error);
                 return new(false, TB("Pandoc is not available on the system or the process had issues."), false, string.Empty, preparedProcess.IsLocal);
             }
 

app/MindWork AI Studio/Tools/PandocExport.cs

@@ -25,11 +25,12 @@ public static class PandocExport
 
         LOGGER.LogInformation($"The user chose the path '{response.SaveFilePath}' for the Microsoft Word export.");
 
-        var tempMarkdownFile = Guid.NewGuid().ToString();
-        var tempMarkdownFilePath = Path.Combine(Path.GetTempPath(), tempMarkdownFile);
-
+        var tempMarkdownFilePath = string.Empty;
         try
         {
+            var tempMarkdownFile = Guid.NewGuid().ToString();
+            tempMarkdownFilePath = Path.Combine(Path.GetTempPath(), tempMarkdownFile);
+            
             // Extract text content from chat:
             var markdownText = markdownContent switch
             {
@@ -80,11 +81,18 @@ public static class PandocExport
                 return false;
             }
 
+            // Read output streams asynchronously while the process runs (prevents deadlock):
+            var outputTask = process.StandardOutput.ReadToEndAsync();
+            var errorTask = process.StandardError.ReadToEndAsync();
+
+            // Wait for the process to exit AND for streams to be fully read:
             await process.WaitForExitAsync();
+            await outputTask;
+            var error = await errorTask;
+
             if (process.ExitCode is not 0)
             {
-                var error = await process.StandardError.ReadToEndAsync();
-                LOGGER.LogError($"Pandoc failed with exit code {process.ExitCode}: {error}");
+                LOGGER.LogError("Pandoc failed with exit code {ProcessExitCode}: '{ErrorText}'", process.ExitCode, error);
                 await MessageBus.INSTANCE.SendError(new(Icons.Material.Filled.Cancel, TB("Error during Microsoft Word export")));
                 return false;
             }
@@ -103,13 +111,16 @@ public static class PandocExport
         finally
         {
             // Try to remove the temp file:
-            try
+            if (!string.IsNullOrWhiteSpace(tempMarkdownFilePath))
             {
-                File.Delete(tempMarkdownFilePath);
-            }
-            catch
-            {
-                LOGGER.LogWarning($"Was not able to delete temporary file: '{tempMarkdownFilePath}'");
+                try
+                {
+                    File.Delete(tempMarkdownFilePath);
+                }
+                catch
+                {
+                    LOGGER.LogWarning($"Was not able to delete temporary file: '{tempMarkdownFilePath}'");
+                }
             }
         }
     }