Moved warnings to code review

This commit is contained in:
Thorsten Sommer 2025-06-30 08:49:41 +02:00
parent 180e55c8ae
commit 429f9a566e
Signed by: tsommer
GPG Key ID: 371BBA77A02C0108

View File

@ -6,8 +6,6 @@ namespace AIStudio.Tools;
public static class ContentStreamSseHandler public static class ContentStreamSseHandler
{ {
private static readonly ConcurrentDictionary<string, List<ContentStreamPptxImageData>> PPTX_IMAGES = new(); private static readonly ConcurrentDictionary<string, List<ContentStreamPptxImageData>> PPTX_IMAGES = new();
#warning We must used a ConcurrentDictionary as well for multiple parallel embeddings
private static int CURRENT_SLIDE_NUMBER; private static int CURRENT_SLIDE_NUMBER;
public static string ProcessEvent(ContentStreamSseEvent? sseEvent, bool extractImages = true) public static string ProcessEvent(ContentStreamSseEvent? sseEvent, bool extractImages = true)
@ -74,7 +72,6 @@ public static class ContentStreamSseHandler
if (string.IsNullOrWhiteSpace(contentStreamPptxImageData.Id)) if (string.IsNullOrWhiteSpace(contentStreamPptxImageData.Id))
return false; return false;
#warning Image IDs must be unique across all parallel embeddings. Use a GUID or similar as prefix.
var id = contentStreamPptxImageData.Id; var id = contentStreamPptxImageData.Id;
var segment = contentStreamPptxImageData.Segment ?? 0; var segment = contentStreamPptxImageData.Segment ?? 0;
var content = contentStreamPptxImageData.Content ?? string.Empty; var content = contentStreamPptxImageData.Content ?? string.Empty;