Added an option to configure the timeout setting for all requests (#746)

Co-authored-by: Thorsten Sommer <SommerEngineering@users.noreply.github.com>

app/MindWork AI Studio/Tools/ERIClient/ERIClientBase.cs

@@ -23,10 +23,7 @@ public abstract class ERIClientBase(IERIDataSource dataSource) : IDisposable
         }
     };
     
-    protected readonly HttpClient HttpClient = new()
-    {
-        BaseAddress = new Uri($"{dataSource.Hostname}:{dataSource.Port}"),
-    };
+    protected readonly HttpClient HttpClient = ExternalHttpClientTimeout.CreateHttpClient(new Uri($"{dataSource.Hostname}:{dataSource.Port}"));
     
     protected string SecurityToken = string.Empty;
     

app/MindWork AI Studio/Tools/ExternalHttpClientTimeout.cs

@@ -0,0 +1,81 @@
+using AIStudio.Settings;
+
+namespace AIStudio.Tools;
+
+/// <summary>
+/// Provides utility methods to standardize the management of HTTP client timeouts
+/// across various components in the application.
+/// </summary>
+public static class ExternalHttpClientTimeout
+{
+    public const int MIN_HTTP_CLIENT_TIMEOUT_SECONDS = 120;
+    public const int MAX_HTTP_CLIENT_TIMEOUT_SECONDS = 3600;
+    public const int DEFAULT_HTTP_CLIENT_TIMEOUT_SECONDS = 3600;
+
+    private static readonly Lazy<SettingsManager> SETTINGS_MANAGER = new(() => Program.SERVICE_PROVIDER.GetRequiredService<SettingsManager>());
+
+    public static HttpClient CreateHttpClient(Uri? baseAddress = null)
+    {
+        var httpClient = new HttpClient();
+        Configure(httpClient, baseAddress);
+        return httpClient;
+    }
+
+    public static string GetTimeoutDescription()
+    {
+        var timeout = GetTimeout();
+
+        if (timeout.TotalHours >= 1 && timeout.TotalMinutes % 60 == 0)
+        {
+            var hours = (int)timeout.TotalHours;
+            return hours == 1 ? "1 hour" : $"{hours} hours";
+        }
+
+        if (timeout.TotalMinutes >= 1 && timeout.TotalSeconds % 60 == 0)
+        {
+            var minutes = (int)timeout.TotalMinutes;
+            return minutes == 1 ? "1 minute" : $"{minutes} minutes";
+        }
+
+        var seconds = (int)timeout.TotalSeconds;
+        return seconds == 1 ? "1 second" : $"{seconds} seconds";
+    }
+
+    public static CancellationTokenSource CreateTimeoutTokenSource(CancellationToken cancellationToken)
+    {
+        var timeoutTokenSource = CancellationTokenSource.CreateLinkedTokenSource(cancellationToken);
+        timeoutTokenSource.CancelAfter(GetTimeout());
+        return timeoutTokenSource;
+    }
+
+    public static bool IsTimeoutException(Exception exception, CancellationToken userCancellationToken = default)
+    {
+        if (userCancellationToken.IsCancellationRequested)
+            return false;
+
+        if (exception is TimeoutException)
+            return true;
+
+        if (exception is OperationCanceledException)
+            return true;
+
+        return exception.InnerException is not null && IsTimeoutException(exception.InnerException, userCancellationToken);
+    }
+    
+    private static TimeSpan GetTimeout()
+    {
+        var seconds = SETTINGS_MANAGER.Value.ConfigurationData.App.HttpClientTimeoutSeconds;
+        if (seconds <= 0)
+            seconds = DEFAULT_HTTP_CLIENT_TIMEOUT_SECONDS;
+
+        seconds = Math.Clamp(seconds, MIN_HTTP_CLIENT_TIMEOUT_SECONDS, MAX_HTTP_CLIENT_TIMEOUT_SECONDS);
+        return TimeSpan.FromSeconds(seconds);
+    }
+    
+    private static void Configure(HttpClient httpClient, Uri? baseAddress = null)
+    {
+        httpClient.Timeout = GetTimeout();
+        if (baseAddress is not null)
+            httpClient.BaseAddress = baseAddress;
+    }
+}

app/MindWork AI Studio/Tools/PluginSystem/PluginConfiguration.cs

@@ -171,6 +171,9 @@ public sealed class PluginConfiguration(bool isInternal, LuaState state, PluginT
         
         // Config: global voice recording shortcut
         ManagedConfiguration.TryProcessConfiguration(x => x.App, x => x.ShortcutVoiceRecording, this.Id, settingsTable, dryRun);
+
+        // Config: timeout for external HTTP requests
+        ManagedConfiguration.TryProcessConfiguration(x => x.App, x => x.HttpClientTimeoutSeconds, this.Id, settingsTable, dryRun);
         
         // Handle configured LLM providers:
         PluginConfigurationObject.TryParse(PluginConfigurationObjectType.LLM_PROVIDER, x => x.Providers, x => x.NextProviderNum, mainTable, this.Id, ref this.configObjects, dryRun);

app/MindWork AI Studio/Tools/PluginSystem/PluginFactory.Download.cs

@@ -15,7 +15,7 @@ public static partial class PluginFactory
             var serverUrl = configServerUrl.EndsWith('/') ? configServerUrl[..^1] : configServerUrl;
             var downloadUrl = $"{serverUrl}/{configPlugId}.zip";
             
-            using var http = new HttpClient();
+            using var http = ExternalHttpClientTimeout.CreateHttpClient();
             using var request = new HttpRequestMessage(HttpMethod.Get, downloadUrl);
             var response = await http.SendAsync(request, HttpCompletionOption.ResponseHeadersRead, cancellationToken);
             if (!response.IsSuccessStatusCode)
@@ -52,7 +52,7 @@ public static partial class PluginFactory
         try
         {
             await LockHotReloadAsync();
-            using var httpClient = new HttpClient();
+            using var httpClient = ExternalHttpClientTimeout.CreateHttpClient();
             var response = await httpClient.GetAsync(downloadUrl, cancellationToken);
             if (!response.IsSuccessStatusCode)
             {

app/MindWork AI Studio/Tools/PluginSystem/PluginFactory.Loading.cs

@@ -245,6 +245,10 @@ public static partial class PluginFactory
         if(ManagedConfiguration.IsConfigurationLeftOver(x => x.App, x => x.ShortcutVoiceRecording, AVAILABLE_PLUGINS))
             wasConfigurationChanged = true;
 
+        // Check for the external HTTP client timeout:
+        if(ManagedConfiguration.IsConfigurationLeftOver(x => x.App, x => x.HttpClientTimeoutSeconds, AVAILABLE_PLUGINS))
+            wasConfigurationChanged = true;
+
         // Check if audit is required before it can be activated
         if(ManagedConfiguration.IsConfigurationLeftOver(x => x.AssistantPluginAudit, x => x.RequireAuditBeforeActivation, AVAILABLE_PLUGINS))
             wasConfigurationChanged = true;